From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756173Ab0IBPzF (ORCPT ); Thu, 2 Sep 2010 11:55:05 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:44149 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756040Ab0IBPzA (ORCPT ); Thu, 2 Sep 2010 11:55:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=hy3VcWuRvnLswgs9xAYxBTlmjYP33LwBA2oF8D6onJluMFHMuQ1N6+wzZ3WMiIIGI0 QkU3oSA7YXi8zyHeOuG16HC8PNi+JWL0ZBUOmLNURLm9z1Kh5TulKlWnA9msnlHJgVFc b1Clhh0/qDYi1nyigY55rvLonBtbgoFc4gMn4= Date: Thu, 2 Sep 2010 08:54:53 -0700 From: Dmitry Torokhov To: Axel Lin Cc: linux-kernel , Ben Dooks , Arnaud Patard , Simtec Electronics , linux-input@vger.kernel.org Subject: Re: [PATCH] Input: s3c2410_ts - fix s3c2410ts_probe error path Message-ID: <20100902155453.GA16914@core.coreip.homeip.net> References: <1283415916.19272.1.camel@mola> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1283415916.19272.1.camel@mola> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 02, 2010 at 04:25:16PM +0800, Axel Lin wrote: > Use input_free_device() to free devices that have not been registered. > > Signed-off-by: Axel Lin Applied, thanks Axel. > --- > drivers/input/touchscreen/s3c2410_ts.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c > index 6085d12..8feb7f3 100644 > --- a/drivers/input/touchscreen/s3c2410_ts.c > +++ b/drivers/input/touchscreen/s3c2410_ts.c > @@ -350,7 +350,7 @@ static int __devinit s3c2410ts_probe(struct platform_device *pdev) > err_tcirq: > free_irq(ts.irq_tc, ts.input); > err_inputdev: > - input_unregister_device(ts.input); > + input_free_device(ts.input); > err_iomap: > iounmap(ts.io); > err_clk: > -- > 1.7.2 > > > -- Dmitry