From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Todd Fischer <todd.fischer@ridgerun.com>,
linux-input@vger.kernel.org
Subject: Re: Input: tps6507x-ts - add missing platform_set_drvdata() in tps6507x_ts_probe()
Date: Thu, 2 Sep 2010 08:55:26 -0700 [thread overview]
Message-ID: <20100902155525.GB16914@core.coreip.homeip.net> (raw)
In-Reply-To: <1283419241.19272.9.camel@mola>
On Thu, Sep 02, 2010 at 05:20:41PM +0800, Axel Lin wrote:
> We call platform_get_drvdata() in tps6507x_ts_remove(),
> thus we should call platform_set_drvdata() in tps6507x_ts_probe().
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks Axel.
> ---
> drivers/input/touchscreen/tps6507x-ts.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
> index a644d18..7286209 100644
> --- a/drivers/input/touchscreen/tps6507x-ts.c
> +++ b/drivers/input/touchscreen/tps6507x-ts.c
> @@ -335,6 +335,7 @@ static int tps6507x_ts_probe(struct platform_device *pdev)
> dev_err(tsc->dev, "schedule failed");
> goto err2;
> }
> + platform_set_drvdata(pdev, tps6507x_dev);
>
> return 0;
>
> --
> 1.7.2
>
>
>
--
Dmitry
prev parent reply other threads:[~2010-09-02 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 9:20 Axel Lin
2010-09-02 15:55 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902155525.GB16914@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=axel.lin@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=todd.fischer@ridgerun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®