From: Richard Cochran <richardcochran@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH 1/2] posix clocks: introduce a syscall for clock tuning.
Date: Fri, 3 Sep 2010 11:58:32 +0200 [thread overview]
Message-ID: <20100903095832.GA22138@riccoc20.at.omicron.at> (raw)
In-Reply-To: <7f4815cdfcf5bc49df4bdd09d59a4f56ca2598f5.1283504065.git.richard.cochran@omicron.at>
On Fri, Sep 03, 2010 at 11:29:05AM +0200, Richard Cochran wrote:
> +long compat_sys_clock_adjtime(clockid_t which_clock,
> + struct compat_timex __user *utp)
> +{
> + struct timex txc;
> + mm_segment_t oldfs;
> + int err, ret;
> +
> + err = compat_get_timex(&txc, utp);
> + if (err)
> + return err;
> +
> + oldfs = get_fs();
> + set_fs(KERNEL_DS);
> + ret = sys_clock_adjtime(which_clock, (struct timex __user *) &txc);
> + set_fs(oldfs);
I don't know what the purpose of get_fs, set_fs is, but the other
clock_ functions have it that way. The adjtimex call does not have
this at all, so I ask, do we need this here, or not?
Thanks,
Richard
next prev parent reply other threads:[~2010-09-03 9:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 9:27 [PATCH 0/2] [RFC] posix " Richard Cochran
2010-09-03 9:29 ` [PATCH 1/2] posix clocks: introduce a syscall for " Richard Cochran
2010-09-03 9:58 ` Richard Cochran [this message]
2010-09-04 14:06 ` Richard Cochran
2010-09-09 10:49 ` Thomas Gleixner
2010-09-09 13:34 ` Richard Cochran
2010-09-09 20:10 ` Thomas Gleixner
2010-09-09 21:16 ` Thomas Gleixner
2010-09-09 22:53 ` john stultz
2010-09-10 9:23 ` Richard Cochran
2010-09-09 21:01 ` john stultz
2010-09-09 21:31 ` Thomas Gleixner
2010-09-03 9:30 ` [PATCH 2/2] posix clocks: introduce a sysfs presence Richard Cochran
2010-09-09 22:19 ` john stultz
2010-09-09 23:00 ` Alan Cox
2010-09-10 9:31 ` Richard Cochran
2010-09-11 0:20 ` Greg KH
2010-09-04 17:23 ` [PATCH 0/2] [RFC] posix clock tuning Christoph Lameter
2010-09-04 17:48 ` Christian Riesch
2010-09-05 1:37 ` Christoph Lameter
2010-09-05 5:56 ` Richard Cochran
2010-09-05 1:47 ` Christoph Lameter
2010-09-05 6:22 ` Richard Cochran
2010-09-05 7:20 ` Richard Cochran
2010-09-05 23:13 ` Christoph Lameter
2010-09-06 7:09 ` Richard Cochran
2010-09-09 9:58 ` Thomas Gleixner
2010-09-09 12:21 ` Richard Cochran
2010-09-09 12:50 ` Thomas Gleixner
2010-09-09 15:02 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100903095832.GA22138@riccoc20.at.omicron.at \
--to=richardcochran@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®