From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Masayuki Ohtak <masa-korg@dsn.okisemi.com>
Cc: "Jean Delvare (PC drivers, core)" <khali@linux-fr.org>,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
Crane Cai <crane.cai@amd.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Ralf Baechle <ralf@linux-mips.org>,
srinidhi kasagar <srinidhi.kasagar@stericsson.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
joe@perches.com, yong.y.wang@intel.com, qi.wang@intel.com,
andrew.chih.howe.khor@intel.com, arjan@linux.intel.com,
Tomoya MORINAGA <morinaga526@dsn.okisemi.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_I2C driver to 2.6.35
Date: Fri, 3 Sep 2010 13:36:13 +0100 [thread overview]
Message-ID: <20100903133613.1c519c49@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4C80CBC0.5050908@dsn.okisemi.com>
> +config PCH_I2C_CH_COUNT
> + int "PCH I2C the number of channel count"
> + range 1 2
> + depends on PCH_I2C
> + help
> + This driver is for PCH(Platform controller Hub) I2C of Topcliff which
> + is an IOH(Input/Output Hub) for x86 embedded processor.
> + The number of I2C buses/channels supported by the PCH I2C controller.
> + PCH I2C of Topcliff supports only one channel.
These sort of settings need to be runtime so one kernel can be built for
many platform variants. In this case if I understand correctly the
current device only has one channel so the define could just be moved
into the driver for now and made a variable later as/when/if new hardware
with more channels appears.
> +static s32 pch_wait_for_xfer_complete(struct i2c_algo_pch_data *adap)
> +{
> + s32 ret;
> + ret = wait_event_interruptible_timeout(pch_event,
> + (adap->pch_event_flag != 0), msecs_to_jiffies(50));
> + if (ret < 0) {
> + pch_err(adap, "timeout: %x\n", adap->pch_event_flag);
> + return ret;
> + }
You are reporting a timeout when _interruptible can also be woken by a
signal to the process (eg the user hitting ^C)
next prev parent reply other threads:[~2010-09-03 12:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 10:19 Masayuki Ohtak
2010-09-03 12:36 ` Alan Cox [this message]
2010-09-03 12:26 ` Wolfram Sang
2010-09-06 0:44 ` Masayuki Ohtake
2010-09-06 0:43 ` Masayuki Ohtake
2010-09-07 23:55 ` Ben Dooks
2010-09-08 12:06 ` Masayuki Ohtake
-- strict thread matches above, loose matches on Subject: below --
2010-09-06 1:31 Masayuki Ohtak
2010-09-06 1:10 Masayuki Ohtak
2010-09-03 7:15 Masayuki Ohtak
2010-09-03 8:10 ` Joe Perches
2010-09-03 10:01 ` Masayuki Ohtake
2010-09-03 3:19 Masayuki Ohtak
2010-09-03 4:38 ` Joe Perches
2010-09-03 8:39 ` Linus WALLEIJ
2010-09-01 2:26 Masayuki Ohtak
2010-09-01 2:43 ` Joe Perches
2010-09-01 4:16 ` Masayuki Ohtake
2010-09-01 5:08 ` Masayuki Ohtake
2010-09-01 5:24 ` Joe Perches
2010-09-01 5:44 ` Masayuki Ohtake
2010-09-01 19:44 ` Linus Walleij
2010-09-03 3:12 ` Masayuki Ohtake
[not found] <4C5B9094.5090205@dsn.okisemi.com>
[not found] ` <4C5B9229.1040403@linux.intel.com>
2010-09-01 1:50 ` Masayuki Ohtake
[not found] ` <20100806142418.GA4921@suse.de>
2010-09-01 1:57 ` Masayuki Ohtake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100903133613.1c519c49@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=andrew.chih.howe.khor@intel.com \
--cc=arjan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=crane.cai@amd.com \
--cc=joe@perches.com \
--cc=khali@linux-fr.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masa-korg@dsn.okisemi.com \
--cc=morinaga526@dsn.okisemi.com \
--cc=qi.wang@intel.com \
--cc=ralf@linux-mips.org \
--cc=sameo@linux.intel.com \
--cc=srinidhi.kasagar@stericsson.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®