From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Luotao Fu <l.fu@pengutronix.de>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: stmpe-ts - return -ENOMEM if memory allocation fail
Date: Fri, 3 Sep 2010 14:45:40 -0700 [thread overview]
Message-ID: <20100903214540.GB6412@core.coreip.homeip.net> (raw)
In-Reply-To: <20100903213524.GA32515@pengutronix.de>
On Fri, Sep 03, 2010 at 11:35:24PM +0200, Wolfram Sang wrote:
> On Fri, Sep 03, 2010 at 09:32:13AM +0800, Axel Lin wrote:
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Basically correct. Should be simpler to just use
>
> int ret = -ENOMEM;
>
> though.
>
No! I hate when people initialize error values like that, because it is
so easy to miss the case and end up with wrong value. If the original
version of the driver did not initialize it to 0 compiler would warn
the author and the error would not make it into the mainline to begin
with.
Please explicitly assign error codes in error handling path.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-09-03 21:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 1:30 [PATCH 1/2] Input: stmpe-ts - remove input_free_device() in stmpe_ts_remove() Axel Lin
2010-09-03 1:32 ` [PATCH 2/2] Input: stmpe-ts - return -ENOMEM if memory allocation fail Axel Lin
2010-09-03 21:35 ` Wolfram Sang
2010-09-03 21:45 ` Dmitry Torokhov [this message]
2010-09-04 5:45 ` Wolfram Sang
2010-09-03 7:13 ` [PATCH 1/2] Input: stmpe-ts - remove input_free_device() in stmpe_ts_remove() Luotao Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100903214540.GB6412@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=axel.lin@gmail.com \
--cc=l.fu@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®