From: Sam Ravnborg <sam@ravnborg.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: akpm@linux-foundation.org, miklos@szeredi.hu, jdike@addtoit.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] uml: disable CONFIG_HAS_DMA
Date: Sat, 4 Sep 2010 12:13:13 +0200 [thread overview]
Message-ID: <20100904101313.GA26489@merkur.ravnborg.org> (raw)
In-Reply-To: <20100904181622P.fujita.tomonori@lab.ntt.co.jp>
On Sat, Sep 04, 2010 at 06:17:56PM +0900, FUJITA Tomonori wrote:
> I think that it's better to detect DMA misuse at build time rather
> than calling BUG_ON. Architectures that can't do DMA need to disable
> CONFIG_HAS_DMA.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> ---
> arch/um/Kconfig.um | 3 +
> arch/um/defconfig | 1 -
> arch/um/include/asm/dma-mapping.h | 112 -------------------------------------
> 3 files changed, 3 insertions(+), 113 deletions(-)
> delete mode 100644 arch/um/include/asm/dma-mapping.h
>
> diff --git a/arch/um/Kconfig.um b/arch/um/Kconfig.um
> index ec2b8da..3de40b8 100644
> --- a/arch/um/Kconfig.um
> +++ b/arch/um/Kconfig.um
> @@ -147,3 +147,6 @@ config KERNEL_STACK_ORDER
> This option determines the size of UML kernel stacks. They will
> be 1 << order pages. The default is OK unless you're running Valgrind
> on UML, in which case, set this to 3.
> +
> +config HAS_DMA
> + def_bool n
Other archs define NO_DMA to say they do not have DMA.
We should do it the same way for um.
Sam
next prev parent reply other threads:[~2010-09-04 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-04 9:17 FUJITA Tomonori
2010-09-04 10:13 ` Sam Ravnborg [this message]
2010-09-04 10:31 ` FUJITA Tomonori
2010-09-04 11:18 ` Sam Ravnborg
2010-09-06 10:55 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100904101313.GA26489@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®