mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Kyle McMartin <kyle@mcmartin.ca>
Cc: linux-kbuild@vger.kernel.org, aris@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: fix oldnoconfig to do the right thing
Date: Sun, 5 Sep 2010 08:17:58 +0200	[thread overview]
Message-ID: <20100905061758.GA29547@merkur.ravnborg.org> (raw)
In-Reply-To: <20100901152130.GY2684@bombadil.infradead.org>

On Wed, Sep 01, 2010 at 11:21:30AM -0400, Kyle McMartin wrote:
> From: Kyle McMartin <kyle@redhat.com>
> 
> Commit 861b4ea4 broke oldnoconfig when removed the oldnoconfig checks on
>                        if (input_mode == nonint_oldconfig ||
>                            input_mode == oldnoconfig) {
>                                if (input_mode == nonint_oldconfig &&
>                                    sym->name &&
>                                     !sym_is_choice_value(sym)) {
> to avoid oldnoconfig chugging through the else stanza.
> 
> Fix that to restore expected behaviour (which I've confirmed in the
> Fedora kernel build that the configs end up looking the same.)

I played aroud with this.
I looks like the only difference I got was that before
your patch oldnoconfig produced a lot of output to stdout.
With your patch is was silent.

The resulting config was the same.

We obviously want the silent variant.

Acked-by: Sam Ravnborg <sam@ravnborg.org>

  reply	other threads:[~2010-09-05  6:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01 15:21 Kyle McMartin
2010-09-05  6:17 ` Sam Ravnborg [this message]
2010-09-08 11:55   ` Michal Marek
2010-09-08 13:01     ` Kyle McMartin
2010-10-08 14:36     ` Kyle McMartin
2010-10-08 14:54       ` Michal Marek
2010-10-08 15:12         ` Kyle McMartin
2010-10-09 19:38           ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100905061758.GA29547@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=aris@redhat.com \
    --cc=kyle@mcmartin.ca \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®