mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Bill Pemberton <wfp5p@virginia.edu>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Arnaud Patard <apatard@mandriva.com>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	Huang Weiyi <weiyi.huang@gmail.com>
Subject: Re: [PATCH 2/4] staging: xgifb: Add compilation conditionals
Date: Sat, 4 Sep 2010 23:24:26 -0700	[thread overview]
Message-ID: <20100905062426.GB18329@suse.de> (raw)
In-Reply-To: <1283641668.9641.5.camel@lenovo>

On Sat, Sep 04, 2010 at 07:07:48PM -0400, Javier Martinez Canillas wrote:
> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
> ---
>  drivers/staging/xgifb/XGI_main.h    |    2 ++
>  drivers/staging/xgifb/XGI_main_26.c |    6 ++++++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h
> index 72448e8..93837f3 100644
> --- a/drivers/staging/xgifb/XGI_main.h
> +++ b/drivers/staging/xgifb/XGI_main.h
> @@ -345,7 +345,9 @@ static int XGIfb_userom = 0;
>  static int XGIfb_registered;
>  static int XGIfb_tvmode = 0;
>  static int XGIfb_mem = 0;
> +#ifndef MODULE
>  static int XGIfb_pdc = 0;
> +#endif

Ick, no, don't add conditionals, fix the code to not need such nonsense.

thanks,

greg k-h

      reply	other threads:[~2010-09-05  6:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-04 23:07 Javier Martinez Canillas
2010-09-05  6:24 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100905062426.GB18329@suse.de \
    --to=gregkh@suse.de \
    --cc=apatard@mandriva.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martinez.javier@gmail.com \
    --cc=randy.dunlap@oracle.com \
    --cc=weiyi.huang@gmail.com \
    --cc=wfp5p@virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome