From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756093Ab0IGBj6 (ORCPT ); Mon, 6 Sep 2010 21:39:58 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:57934 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756002Ab0IGBju (ORCPT ); Mon, 6 Sep 2010 21:39:50 -0400 Date: Mon, 06 Sep 2010 18:40:07 -0700 (PDT) Message-Id: <20100906.184007.58449609.davem@davemloft.net> To: julia@diku.dk Cc: chas@cmf.nrl.navy.mil, kernel-janitors@vger.kernel.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] drivers/atm/firestream.c: Fix unsigned return type From: David Miller In-Reply-To: <1283713226-8429-6-git-send-email-julia@diku.dk> References: <1283713226-8429-1-git-send-email-julia@diku.dk> <1283713226-8429-6-git-send-email-julia@diku.dk> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall Date: Sun, 5 Sep 2010 21:00:23 +0200 > The function has an unsigned return type, but returns a negative constant > to indicate an error condition. The result of calling the function is > always stored in a variable of type (signed) int, and thus unsigned can be > dropped from the return type. > > A sematic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall Applied.