From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ben Hutchings <ben@decadent.org.uk>,
linux-kernel@vger.kernel.org,
vamos-dev@i4.informatik.uni-erlangen.de
Subject: Re: [PATCH 12/14] include/linux: Removing undead ifdef __KERNEL__
Date: Mon, 6 Sep 2010 20:16:15 +0400 [thread overview]
Message-ID: <20100906161615.GB6431@lenovo> (raw)
In-Reply-To: <982ff35c4e79349b4bc4a224a6134e1c5ec38431.1283782701.git.qy03fugy@stud.informatik.uni-erlangen.de>
On Mon, Sep 06, 2010 at 04:36:59PM +0200, Christian Dietrich wrote:
> The __KERNEL__ ifdef isn't necessary at this point, because it is
> checked in an outer ifdef level already and has no effect here.
>
> Signed-off-by: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>
> ---
The origin looks weird indeed. So I presume it's here for historical reasons.
Well, from git log it shows a lot of glibc tricks were here. And the former
top __KERNEL__ is by commit 9c501935a3cdcf6b1d35aaee3aa11c7a7051a305 so
Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
Thanks Christian
-- Cyrill
next prev parent reply other threads:[~2010-09-06 16:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1283782698.git.qy03fugy@stud.informatik.uni-erlangen.de>
2010-09-06 14:35 ` [PATCH 01/14] arch/arm: Removing undead ifdef __ASSEMBLY__ Christian Dietrich
2010-09-06 14:36 ` [PATCH 02/14] arch/h8300: Removing dead ifdef __H8300_TLB_H__ Christian Dietrich
2010-09-06 18:32 ` Andreas Schwab
2010-09-06 14:36 ` [PATCH 03/14] arch/parisc: Removing undead ifdef CONFIG_PA20 Christian Dietrich
2010-09-08 21:18 ` Kyle McMartin
2010-09-06 14:36 ` [PATCH 04/14] arch/{s390,powerpc}: Removing undead ifdef __KERNEL__ Christian Dietrich
2010-09-06 14:36 ` [PATCH 05/14] arch/x86: Removing undead ifdef ACPI/X86_IO_ACPI Christian Dietrich
2010-09-06 14:57 ` Borislav Petkov
2010-09-08 8:35 ` [tip:x86/cleanups] x86: Remove unnecessary #ifdef ACPI/X86_IO_ACPI tip-bot for Christian Dietrich
2010-09-06 14:36 ` [PATCH 06/14] drivers/net: Removing undead ifdef CHELSIO_T1_1G Christian Dietrich
2010-09-07 1:39 ` David Miller
2010-09-06 14:36 ` [PATCH 07/14] drivers/scsi: Removing undead ifdef __ISAPNP__ Christian Dietrich
2010-09-06 14:36 ` [PATCH 08/14] drivers/scsi: Removing undead ifdef CONFIG_PCI Christian Dietrich
2010-09-06 14:36 ` [PATCH 09/14] drivers/scsi: Removing undead ifdef REAL_DMA Christian Dietrich
2010-09-06 14:36 ` [PATCH 10/14] drivers/video: Removing undead ifdef ATAFB_FALCON Christian Dietrich
2010-09-10 17:50 ` Krzysztof Helt
2010-10-03 8:15 ` Geert Uytterhoeven
2010-09-06 14:36 ` [PATCH 11/14] drivers/video: Removing undead ifdef CONFIG_FB_MATROX_G Christian Dietrich
2010-09-07 13:02 ` Jean Delvare
2010-09-06 14:36 ` [PATCH 12/14] include/linux: Removing undead ifdef __KERNEL__ Christian Dietrich
2010-09-06 16:16 ` Cyrill Gorcunov [this message]
2010-09-06 14:37 ` [PATCH 13/14] kernel/: Removing undead ifdef CONFIG_SMP Christian Dietrich
2010-09-08 8:36 ` [tip:sched/core] sched: Remove unnecessary #ifdef CONFIG_SMP tip-bot for Christian Dietrich
2010-09-06 14:37 ` [PATCH 14/14] kernel/: Removing undead ifdef CONFIG_DEBUG_LOCK_ALLOC Christian Dietrich
2010-09-06 16:13 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100906161615.GB6431@lenovo \
--to=gorcunov@gmail.com \
--cc=acme@redhat.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qy03fugy@stud.informatik.uni-erlangen.de \
--cc=vamos-dev@i4.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®