From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756773Ab0IGNNP (ORCPT ); Tue, 7 Sep 2010 09:13:15 -0400 Received: from mv-drv-hcb003.ocn.ad.jp ([118.23.109.133]:50451 "EHLO mv-drv-hcb003.ocn.ad.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756576Ab0IGNNK (ORCPT ); Tue, 7 Sep 2010 09:13:10 -0400 Date: Tue, 07 Sep 2010 22:13:07 +0900 (JST) Message-Id: <20100907.221307.39158422.anemo@mba.ocn.ne.jp> To: cernekee@gmail.com Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] MIPS: Move FIXADDR_TOP into spaces.h From: Atsushi Nemoto In-Reply-To: References: X-Fingerprint: 6ACA 1623 39BD 9A94 9B1A B746 CA77 FE94 2874 D52F X-Pgp-Public-Key: http://wwwkeys.pgp.net/pks/lookup?op=get&search=0x2874D52F X-Mailer: Mew version 5.2 on Emacs 22.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Sep 2010 21:03:52 -0700, Kevin Cernekee wrote: > -#define FIXADDR_TOP ((unsigned long)(long)(int)0xfffe0000) ... > +#define FIXADDR_TOP _AC(0xfffe0000, UL) For 64-bit kernel, FIXADDR_TOP should be 0xfffffffffffe0000UL not 0x00000000fffe0000UL. The magical casts are used to sign-extend the address. Please do not drop them. --- Atsushi Nemoto