From: Lutz Ballaschke <vegan.grindcore@googlemail.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: me@mortis.eu, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: add f71862fg support
Date: Sat, 11 Sep 2010 01:24:07 +0200 [thread overview]
Message-ID: <20100910232407.GA13116@kreios.titan> (raw)
In-Reply-To: <20100910090301.GS354@infomag.iguana.be>
On Fri, Sep 10, 2010 at 11:03:01AM +0200, Wim Van Sebroeck wrote:
>
> > Given that the F71862 has *two* pins assignable to the WDTRST# signal,
> > please document that fact, and the reason for choosing this one in the
> > code.
> >
> > Perhaps it might even be desirable to insert a printk there. This to
> > make the user aware of the fact that this driver might not work if the
> > pin configuration of their hardware doesn't match the assumption you
> > make about it in this code.
>
> I propose to Document it in the code and add a module-parameter so that it is selectable.
>
I agree. I will post the patch again (missing parts will follow soon).
I placed printk in watchdog_start(). Since this means printk output
everytime /dev/watchdog is opened I'm not sure whether i like it there.
Maybe it fits better in f71808e_find(). But this would require
additional if / else and stuff.
Regards,
Lutz Ballaschke
next prev parent reply other threads:[~2010-09-10 23:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 13:24 Lutz Ballaschke
2010-09-07 13:18 ` Giel van Schijndel
2010-09-10 9:03 ` Wim Van Sebroeck
2010-09-10 23:24 ` Lutz Ballaschke [this message]
2010-09-10 23:48 ` Giel van Schijndel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910232407.GA13116@kreios.titan \
--to=vegan.grindcore@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=me@mortis.eu \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®