From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Vladislav Bolkhovitin <vst@vlnb.net>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
scst-devel <scst-devel@lists.sourceforge.net>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Andrew Morton <akpm@linux-foundation.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Mike Christie <michaelc@cs.wisc.edu>,
Jeff Garzik <jeff@garzik.org>, Vu Pham <vuhuong@mellanox.com>,
Bart Van Assche <bart.vanassche@gmail.com>,
James Smart <James.Smart@Emulex.Com>,
Joe Eykholt <jeykholt@cisco.com>, Andy Yan <ayan@marvell.com>,
Chetan Loke <generationgnu@yahoo.com>,
Hannes Reinecke <hare@suse.de>,
Richard Sharpe <realrichardsharpe@gmail.com>
Subject: Re: [PATCH 0/17]: New SCSI target framework (SCST) with dev handlers and 2 target drivers
Date: Tue, 14 Sep 2010 22:56:49 -0700 [thread overview]
Message-ID: <20100915055649.GB22219@core.coreip.homeip.net> (raw)
In-Reply-To: <4C8F886E.2080407@vlnb.net>
Hi Vladislav,
On Tue, Sep 14, 2010 at 06:36:30PM +0400, Vladislav Bolkhovitin wrote:
> Hi All,
>
> Please review this second iteration of the patch set of the new
> (although, perhaps, the oldest) SCSI target framework for Linux SCST
> with a set of dev handlers and 2 target drivers: for local access
> (scst_local) and for Infiniband SRP (srpt).
>
I am afraid that the way the code was split into the patches will hinder
the review process. Normally every patch consists of a usable on its
own piece of code (or a logically compete change). This way the unit of
work (coding, testing or reviewing) is clearly defined and easier to
comprehend.
Your patch series, unfortunately, splits Makefile and Kconfig changes
separately from the drivers (which will cause build breakages should it
be applied as is and someone needs to bisect), introduces header files
in their entirety even when some of the data there is not needed till
much later, uses facilities (for example sysfs bindings) that have not
been introduced yet... I am afraid you'd have to rework the splitting
process.
Also patch descriptions should be improved:
"This patch contains SYSFS interface implementation"
- what are you trying to solve?
- main points?
- why offloading of actions to a separate thread?
This should be in the patch description.
BTW, why are you using an exclusive thread instead of exclusive
workqueue for this?
Also, kobject_del() + kobject_put() == kobject_unregister().
And too many "naked returns", I believe common style is to only have
return for non-void functions.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-09-15 5:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 14:36 Vladislav Bolkhovitin
2010-09-14 14:37 ` [PATCH 1/17]: Integration of SCST into the Linux kernel tree Vladislav Bolkhovitin
2010-09-14 14:38 ` [PATCH 2/17]: SCST core's Makefile and Kconfig Vladislav Bolkhovitin
2010-09-14 14:39 ` [PATCH 3/17]: SCST public headers Vladislav Bolkhovitin
2010-09-14 14:40 ` [PATCH 4/17]: SCST main management files and private headers Vladislav Bolkhovitin
2010-09-14 14:41 ` [PATCH 5/17]: SCST implementation of the SCSI target state machine Vladislav Bolkhovitin
2010-09-14 14:42 ` [PATCH 6/17]: SCST internal library functions Vladislav Bolkhovitin
2010-09-14 14:43 ` [PATCH 7/17]: SCST Persistent Reservations implementation Vladislav Bolkhovitin
2010-09-14 14:44 ` [PATCH 8/17]: SCST SYSFS interface implementation Vladislav Bolkhovitin
2010-09-14 14:44 ` [PATCH 9/17]: SCST debugging support routines Vladislav Bolkhovitin
2010-09-14 14:45 ` [PATCH 10/17]: SCST SGV cache Vladislav Bolkhovitin
2010-09-14 14:45 ` [PATCH 11/17]: SCST core's docs Vladislav Bolkhovitin
2010-09-14 14:46 ` [PATCH 12/17]: SCST dev handlers' Makefile Vladislav Bolkhovitin
2010-09-14 14:47 ` [PATCH 13/17]: SCST vdisk dev handler Vladislav Bolkhovitin
2010-09-14 14:48 ` [PATCH 14/17]: SCST pass-through dev handlers Vladislav Bolkhovitin
2010-09-14 14:49 ` [PATCH 15/17]: Implementation of blk_rq_map_kern_sg() Vladislav Bolkhovitin
2010-09-14 14:50 ` [PATCH 16/17]: scst_local target driver Vladislav Bolkhovitin
2010-09-14 14:51 ` [PATCH 17/17]: SCST InfiniBand SRP " Vladislav Bolkhovitin
2010-09-15 5:56 ` Dmitry Torokhov [this message]
2010-09-15 14:52 ` [PATCH 0/17]: New SCSI target framework (SCST) with dev handlers and 2 target drivers Vladislav Bolkhovitin
2010-09-15 18:07 ` Vladislav Bolkhovitin
2010-09-19 9:54 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915055649.GB22219@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=James.Smart@Emulex.Com \
--cc=akpm@linux-foundation.org \
--cc=ayan@marvell.com \
--cc=bart.vanassche@gmail.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=generationgnu@yahoo.com \
--cc=hare@suse.de \
--cc=jeff@garzik.org \
--cc=jeykholt@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=realrichardsharpe@gmail.com \
--cc=scst-devel@lists.sourceforge.net \
--cc=vst@vlnb.net \
--cc=vuhuong@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®