From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: "Ted Ts'o" <tytso@mit.edu>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>, Eric Sandeen <sandeen@redhat.com>,
Christoph Hellwig <hch@lst.de>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ext4: fix NULL pointer dereference in print_daily_error_info
Date: Wed, 15 Sep 2010 09:35:18 +0300 [thread overview]
Message-ID: <20100915063517.GA8456@swordfish.minsk.epam.com> (raw)
In-Reply-To: <20100914194641.GB3730@thunk.org>
Fix NULL pointer dereference in print_daily_error_info, when
called on unmounted fs (EXT4_SB(sb) returns NULL), by removing error
reporting timer in ext4_put_super.
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 2614774..751997d 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -719,6 +719,7 @@ static void ext4_put_super(struct super_block *sb)
ext4_abort(sb, "Couldn't clean up the journal");
}
+ del_timer(&sbi->s_err_report);
ext4_release_system_zone(sb);
ext4_mb_release(sb);
ext4_ext_release(sb);
next prev parent reply other threads:[~2010-09-15 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 12:51 Sergey Senozhatsky
2010-09-14 19:46 ` Ted Ts'o
2010-09-15 6:35 ` Sergey Senozhatsky [this message]
2010-09-20 14:21 ` [PATCH] ext4: fix " Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915063517.GA8456@swordfish.minsk.epam.com \
--to=sergey.senozhatsky@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome