From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: kosaki.motohiro@jp.fujitsu.com,
Dave Hansen <dave@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
lnxninja@linux.vnet.ibm.com
Subject: Re: [RFC][PATCH] update /proc/sys/vm/drop_caches documentation
Date: Wed, 15 Sep 2010 13:53:10 +0900 (JST) [thread overview]
Message-ID: <20100915135016.C9F1.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20100915133303.0b232671.kamezawa.hiroyu@jp.fujitsu.com>
> > ==============================================================
> >
> > diff -puN fs/drop_caches.c~update-drop_caches-documentation fs/drop_caches.c
> > --- linux-2.6.git/fs/drop_caches.c~update-drop_caches-documentation 2010-09-14 15:44:29.000000000 -0700
> > +++ linux-2.6.git-dave/fs/drop_caches.c 2010-09-14 15:58:31.000000000 -0700
> > @@ -47,6 +47,8 @@ int drop_caches_sysctl_handler(ctl_table
> > {
> > proc_dointvec_minmax(table, write, buffer, length, ppos);
> > if (write) {
> > + WARN_ONCE(1, "kernel caches forcefully dropped, "
> > + "see Documentation/sysctl/vm.txt\n");
>
> Documentation updeta seems good but showing warning seems to be meddling to me.
Agreed.
If the motivation is blog's bogus rumor, this is no effective. I easily
imazine they will write "Hey, drop_caches may output strange message,
but please ignore it!".
Libenter homines id quod volunt credunt.
Gaius Julius Caesar "Commentarii de Bello Gallico" 3-18
next prev parent reply other threads:[~2010-09-15 4:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 23:47 Dave Hansen
2010-09-15 4:33 ` KAMEZAWA Hiroyuki
2010-09-15 4:53 ` KOSAKI Motohiro [this message]
2010-09-15 6:14 ` Dave Hansen
2010-09-15 18:37 ` Eric W. Biederman
2010-09-15 19:27 ` Dave Hansen
2010-09-15 21:34 ` Eric W. Biederman
2010-09-15 19:24 ` Tim Pepper
2010-09-16 0:12 ` KAMEZAWA Hiroyuki
2010-09-16 1:21 ` Dave Hansen
2010-09-16 1:33 ` KAMEZAWA Hiroyuki
2010-09-24 13:02 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915135016.C9F1.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=dave@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lnxninja@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®