From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753815Ab0IPGWx (ORCPT ); Thu, 16 Sep 2010 02:22:53 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:43070 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752525Ab0IPGWw (ORCPT ); Thu, 16 Sep 2010 02:22:52 -0400 Date: Thu, 16 Sep 2010 09:22:32 +0300 From: Felipe Balbi To: "Gadiyar, Anand" Cc: "Balbi, Felipe" , Sergei Shtylyov , Ming Lei , "greg@kroah.com" , "linux-usb@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , David Brownell , Mike Frysinger Subject: Re: [Discussion] USB: musb-gadget: how to fix ZLP issue in musb_g_tx Message-ID: <20100916062232.GC3393@legolas.emea.dhcp.ti.com> Reply-To: balbi@ti.com References: <20100915105641.GO3393@legolas.emea.dhcp.ti.com> <20100915110745.GP3393@legolas.emea.dhcp.ti.com> <4C90C5B7.7050103@ru.mvista.com> <20100916060520.GA3393@legolas.emea.dhcp.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 16, 2010 at 01:15:32AM -0500, Gadiyar, Anand wrote: >On Thu, Sep 16, 2010 at 11:35 AM, Felipe Balbi wrote: >> Hi, >> >> On Wed, Sep 15, 2010 at 08:10:15AM -0500, Sergei Shtylyov wrote: >>> >>>   I don't see what to rework. The last short packet should still satisfy >>> (request->actual == request->length) condition, no? >> >> of course not, it's short not zero. so the last short packet can be >> anything from 1 to 511 bytes. >> > >If it's TX, both condtions should automatically be true, right? even in mode1 ? I have to revist my docs, but afaict mode1 won't transmit last short packet, no matter if it's tx or rx. Could be wrong, though. -- balbi