From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dan Rosenberg <drosenberg@vsecurity.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
security@kernel.org, stable@kernel.org
Subject: Re: [PATCH] drivers/usb/serial/mos*: prevent reading uninitialized stack memory
Date: Thu, 16 Sep 2010 09:39:22 +0100 [thread overview]
Message-ID: <20100916093922.197ebe18@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1284587056.6275.100.camel@dan>
On Wed, 15 Sep 2010 17:44:16 -0400
Dan Rosenberg <drosenberg@vsecurity.com> wrote:
> The TIOCGICOUNT device ioctl in both mos7720.c and mos7840.c allows
> unprivileged users to read uninitialized stack memory, because the
> "reserved" member of the serial_icounter_struct struct declared on the
> stack is not altered or zeroed before being copied back to the user.
> This patch takes care of it.
ACK ... but this is the wrong way to fix these. We'll be squashing new
ones between here and eternity if we just stick memsets in. It wants
making a tty operation off the tty ioctl code so that there is one place
that clears it and copies it to the user.
I'll have a look at what is needed - I don't think very much.
Alan
prev parent reply other threads:[~2010-09-16 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 21:44 Dan Rosenberg
2010-09-16 8:39 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916093922.197ebe18@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=drosenberg@vsecurity.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=security@kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®