mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: minskey guo <chaohong.guo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, chaohong.guo@intel.com,
	minskey guo <chaohong_guo@linux.intel.com>
Subject: Re: [PATCH]  NULL pointer might be used in ips_monitor()
Date: Thu, 16 Sep 2010 14:53:55 +0200	[thread overview]
Message-ID: <20100916145355.24a55114@jbarnes-x201> (raw)
In-Reply-To: <1284613588-5199-1-git-send-email-chaohong.guo@linux.intel.com>

On Thu, 16 Sep 2010 13:06:28 +0800
minskey guo <chaohong.guo@linux.intel.com> wrote:

> From: minskey guo <chaohong_guo@linux.intel.com>
> 
>  The patch is to enable creating ips_adjust thread before ips_monitor
>  executes because the latter will kthread_stop() or wake up the former
>  via ips->adjust pointer. Otherwise, it is possible that ips->adjust
> is NULL when kthread_stop() or wake_up_process() is called in
> ips_monitor()
> 
>  Besides, some trival changes:
>    a) correct an define of register bits;
>    b) old_cpu_power sample should not be divided by 65535
>    c) handling on error path in ips_get_i915_syms()

Excellent, thanks for the fixes.  Can you split up the patch into
individual fixes and send them over to the platform driver list and
Matthew Garrett?  You can add my acked-by on them.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2010-09-16 12:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-16  5:06 minskey guo
2010-09-16 12:53 ` Jesse Barnes [this message]
2010-09-17  6:08   ` Minskey Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100916145355.24a55114@jbarnes-x201 \
    --to=jbarnes@virtuousgeek.org \
    --cc=chaohong.guo@intel.com \
    --cc=chaohong.guo@linux.intel.com \
    --cc=chaohong_guo@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®