From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752269Ab0IPHdQ (ORCPT ); Thu, 16 Sep 2010 03:33:16 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:54452 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813Ab0IPHdP (ORCPT ); Thu, 16 Sep 2010 03:33:15 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Thu, 16 Sep 2010 16:28:07 +0900 From: KAMEZAWA Hiroyuki To: KAMEZAWA Hiroyuki Cc: balbir@linux.vnet.ibm.com, "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "nishimura@mxp.nes.nec.co.jp" , "akpm@linux-foundation.org" Subject: Re: [PATCH][-mm] memcg : memory cgroup cpu hotplug support update. Message-Id: <20100916162807.d2ae50be.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100916161727.04a1f905.kamezawa.hiroyu@jp.fujitsu.com> References: <20100916144618.852b7e9a.kamezawa.hiroyu@jp.fujitsu.com> <20100916062159.GF22371@balbir.in.ibm.com> <20100916152204.6c457936.kamezawa.hiroyu@jp.fujitsu.com> <20100916161727.04a1f905.kamezawa.hiroyu@jp.fujitsu.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.0.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Sep 2010 16:17:27 +0900 KAMEZAWA Hiroyuki wrote: > On Thu, 16 Sep 2010 15:22:04 +0900 > KAMEZAWA Hiroyuki wrote: > > > This naming is from mem_cgroup_walk_tree(). Now we have > > > > mem_cgroup_walk_tree(); > > mem_cgroup_walk_all(); > > > > Rename both ? But it should be in separated patch. > > > > Considering a bit ...but.. > > #define for_each_mem_cgroup(mem) \ > for (mem = mem_cgroup_get_first(); \ > mem; \ > mem = mem_cgroup_get_next(mem);) \ > > seems to need some helper functions. I'll consider about this clean up > but it requires some amount of patch because css_get()/css_put()/rcu...etc.. > are problematic. Hmm...css_put() at break from loop is a problem... Do you have anything good idea to handle "exit-from-loop" operation with dropping reference count ? I don't like "the caller must take care of" approach. Thanks, -Kame