Re: [PATCH 12/12] BKL: Remove BKL from OCFS2

[Mark Fasheh <mfasheh@suse.com>]

On Thu, Sep 16, 2010 at 07:46:25PM +0200, Arnd Bergmann wrote:
> The BKL in ocfs2/dlmfs is used in put_super, fill_super and remount_fs
> that are all three protected by the superblocks s_umount rw_semaphore.

Those look good, thanks.


> The use in ocfs2_control_open is evidently unrelated and the function
> is protected by ocfs2_control_lock.

<snip>

> @@ -612,12 +611,10 @@ static int ocfs2_control_open(struct inode *inode, struct file *file)
>  		return -ENOMEM;
>  	p->op_this_node = -1;
>  
> -	lock_kernel();
>  	mutex_lock(&ocfs2_control_lock);
>  	file->private_data = p;
>  	list_add(&p->op_list, &ocfs2_control_private_list);
>  	mutex_unlock(&ocfs2_control_lock);
> -	unlock_kernel();
>  
>  	return 0;
>  }

My guess is that this one is good to go too. Joel?
	--Mark

--
Mark Fasheh