From: Greg KH <gregkh@suse.de>
To: pavan_savoy@ti.com
Cc: alan@lxorguk.ukuu.org.uk, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:staging:ti-st: mv headers to ti_wilink_st
Date: Thu, 16 Sep 2010 15:48:29 -0700 [thread overview]
Message-ID: <20100916224829.GB14256@suse.de> (raw)
In-Reply-To: <1284676444-23904-1-git-send-email-pavan_savoy@ti.com>
On Thu, Sep 16, 2010 at 06:34:04PM -0400, pavan_savoy@ti.com wrote:
> From: Pavan Savoy <pavan_savoy@ti.com>
>
> move all the header information to ti_wilink_st.h.
> This header would then not only serve the local modules like the st_core.c,
> st_kim.c and st_ll.c but also the external modules/protocol drivers that are
> dependent on the shared transport driver.
> Also modify the structures to use cleaner u8/u16 types for data coming
> in from chip and data parsed out of firmware.
No!
Don't do more than one thing at once please, do one thing at a time.
One patch to modify the structures.
And one patch to move things together.
thanks,
greg k-h
prev parent reply other threads:[~2010-09-16 22:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 22:34 pavan_savoy
2010-09-16 22:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916224829.GB14256@suse.de \
--to=gregkh@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavan_savoy@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome