From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755278Ab0IQCmn (ORCPT ); Thu, 16 Sep 2010 22:42:43 -0400 Received: from chilli.pcug.org.au ([203.10.76.44]:52715 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752833Ab0IQCmm (ORCPT ); Thu, 16 Sep 2010 22:42:42 -0400 Date: Fri, 17 Sep 2010 12:42:38 +1000 From: Stephen Rothwell To: "Paul E. McKenney" Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , David Miller , Subject: linux-next: build failure after merge of the rcu tree Message-Id: <20100917124238.aa0596cb.sfr@canb.auug.org.au> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, After merging the rcu tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: net/core/dev.c: In function 'netdev_run_todo': net/core/dev.c:5294: error: dereferencing pointer to incomplete type net/core/dev.c:5294: warning: type defaults to 'int' in declaration of '_________p1' net/core/dev.c:5294: error: dereferencing pointer to incomplete type net/core/dev.c:5294: warning: type defaults to 'int' in declaration of 'type name' net/core/dev.c:5294: error: dereferencing pointer to incomplete type net/core/dev.c:5294: warning: type defaults to 'int' in declaration of 'type name' net/core/dev.c:5294: warning: comparison of distinct pointer types lacks a cast net/core/dev.c:5294: error: dereferencing pointer to incomplete type net/core/dev.c:5294: warning: type defaults to 'int' in declaration of 'type name' Caused by commit ca5ecddfa8fcbd948c95530e7e817cee9fb43a3d ("rcu: define __rcu address space modifier for sparse") interacting with commit 95ae6b228f814fc0528d0506ee9f18ac333d6851 ("ipv4: ip_ptr cleanups") from the net tree. rcu_dereference_raw() now needs to know the type of the object its argument points to. I added the following merge fix (which could be applied to the net tree anyway). From: Stephen Rothwell Date: Fri, 17 Sep 2010 12:36:36 +1000 Subject: [PATCH] net: include inetdevice.h for rcu_dereference_raw api change rcu_dereference_raw() now needs to know the type of its argument. Signed-off-by: Stephen Rothwell --- net/core/dev.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index c6d837a..cadd28c 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -129,6 +129,7 @@ #include #include #include +#include #include "net-sysfs.h" -- 1.7.1 -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/