mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Pekka Enberg <penberg@kernel.org>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
	Lars Lindley <lindley@coyote.org>,
	Ruslan Pisarev <ruslan@rpisarev.org.ua>
Subject: Re: [PATCH] w35und: Add locking problems to TODO list
Date: Sun, 19 Sep 2010 23:40:39 +0200	[thread overview]
Message-ID: <20100919214039.GB12416@elf.ucw.cz> (raw)
In-Reply-To: <1284890661-14221-1-git-send-email-penberg@kernel.org>

Hi!

> The w35und uses atomics such as "ThreadCount" and "FireCount" to emulate
> locking in the TX paths, for example. Document this bug in the TODO list.
> 
> Cc: Lars Lindley <lindley@coyote.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Ruslan Pisarev <ruslan@rpisarev.org.ua>
> Signed-off-by: Pekka Enberg <penberg@kernel.org>
> ---
>  drivers/staging/winbond/TODO |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/winbond/TODO b/drivers/staging/winbond/TODO
> index 43bee56..b4c592a 100644
> --- a/drivers/staging/winbond/TODO
> +++ b/drivers/staging/winbond/TODO
> @@ -6,6 +6,7 @@ TODO:
>  	- remove unused ioctls
>  	- use cfg80211 for regulatory stuff
>  	- fix 4k stack problems
> +	- fix locking problems (it's done using atomics...)

Being more verbose here would be good; list all the variables or at
least structures they are in, or something...?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

      reply	other threads:[~2010-09-19 21:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-19 10:04 Pekka Enberg
2010-09-19 21:40 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100919214039.GB12416@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=gregkh@suse.de \
    --cc=lindley@coyote.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@kernel.org \
    --cc=ruslan@rpisarev.org.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®