From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754051Ab0ISXXx (ORCPT ); Sun, 19 Sep 2010 19:23:53 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:54142 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752178Ab0ISXXv (ORCPT ); Sun, 19 Sep 2010 19:23:51 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=jzYgSGELUMDKRmnxfL0hKLb/4sa4LV3qiy7zQlcDLehtLmBV7CsvoW78MwSs5JpLz2 DjJhXj6YAWMslTKPK+2t+glwKLR0j4gO461yyvg6i0rSle6mnRhhjdJkjbY6M8ePHkSQ M5WICmuhCVb7/uQshETiBFOkOc4SoOg6/oge0= Date: Sun, 19 Sep 2010 16:23:44 -0700 From: Dmitry Torokhov To: Henrik Rydberg Cc: Jiri Kosina , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hid: 3m: Output proper orientation range Message-ID: <20100919232343.GA6565@core.coreip.homeip.net> References: <1284886583-30965-1-git-send-email-rydberg@euromail.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1284886583-30965-1-git-send-email-rydberg@euromail.se> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 19, 2010 at 10:56:23AM +0200, Henrik Rydberg wrote: > The range of orientation values for height/width devices should > be [0, 1], but is currently set to [1, 1]. Having min == max also > breaks uinput device setup. Fixed with this patch. > > Signed-off-by: Henrik Rydberg Makes sense. Acked-by: Dmitry Torokhov > --- > drivers/hid/hid-3m-pct.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/hid/hid-3m-pct.c b/drivers/hid/hid-3m-pct.c > index cd4b125..860d47c 100644 > --- a/drivers/hid/hid-3m-pct.c > +++ b/drivers/hid/hid-3m-pct.c > @@ -110,7 +110,7 @@ static int mmm_input_mapping(struct hid_device *hdev, struct hid_input *hi, > input_set_abs_params(hi->input, ABS_MT_TOUCH_MINOR, > f1, f2, df / SN_WIDTH, 0); > input_set_abs_params(hi->input, ABS_MT_ORIENTATION, > - 1, 1, 0, 0); > + 0, 1, 0, 0); > return 1; > case HID_DG_CONTACTID: > field->logical_maximum = MAX_TRKID; > -- > 1.7.1 > -- Dmitry