From: Jonathan Corbet <corbet@lwn.net>
To: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Joseph Chan <JosephChan@via.com.tw>
Subject: Re: [PATCH 05/12] viafb: fix i2c_transfer error handling
Date: Mon, 20 Sep 2010 06:43:54 -0600 [thread overview]
Message-ID: <20100920064354.2fc28219@bike.lwn.net> (raw)
In-Reply-To: <171e0fb74a34b069c0c12aa90c56d5e5da5489c6.1284879532.git.FlorianSchandinat@gmx.de>
On Sun, 19 Sep 2010 07:33:46 +0000
Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:
> i2c_transfer returns negative errno on error and number of messages
> processed on success. Just returning this value would give a poor
> interface as it is not obvious that you must compare with 2 after reading
> 1 or n bytes and with 1 after writing 1 byte to determine if it was
> successful. To avoid this error prone interface convert the error code
> of a successful read/write to zero and all other non-negative values to
> an negative error code.
> This fixes a regression introduced by
> via: Rationalize vt1636 detection
> which resulted in no longer detecting a VT1636 chip and therefore has
> broken the output in configurations wich contain this chip.
>From a quick look, all of these patches look like improvements to me.
This one, since it's a regression fix, should probably have a
Cc: stable@kernel.org in it as well.
Acked-by: Jonathan Corbet <corbet@lwn.net>
jon
next prev parent reply other threads:[~2010-09-20 12:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 7:26 [PATCH 00/12] viafb output device rework - part 2 Florian Tobias Schandinat
2010-09-19 7:26 ` [PATCH 01/12] viafb: add interface for output device configuration Florian Tobias Schandinat
2010-09-21 1:27 ` [PATCH v2] " Florian Tobias Schandinat
2010-09-19 7:26 ` [PATCH 02/12] viafb: limit LCD code impact Florian Tobias Schandinat
2010-09-19 7:26 ` [PATCH 03/12] viafb: introduce per output device power management Florian Tobias Schandinat
2010-09-19 7:26 ` [PATCH 04/12] viafb: vt1636 cleanup Florian Tobias Schandinat
2010-09-19 7:33 ` [PATCH 05/12] viafb: fix i2c_transfer error handling Florian Tobias Schandinat
2010-09-20 12:43 ` Jonathan Corbet [this message]
2010-09-19 7:33 ` [PATCH 06/12] viafb: enable I2C for CRT Florian Tobias Schandinat
2010-09-19 7:33 ` [PATCH 07/12] viafb: reduce I2C timeout and delay Florian Tobias Schandinat
2010-09-19 7:33 ` [PATCH 08/12] viafb: add function to change sync polarity per device Florian Tobias Schandinat
2010-09-19 7:33 ` [PATCH 09/12] viafb: set sync polarity for all output devices Florian Tobias Schandinat
2010-09-19 7:39 ` [PATCH 10/12] viafb: add a mapping of supported " Florian Tobias Schandinat
2010-09-19 7:39 ` [PATCH 11/12] viafb: rename " Florian Tobias Schandinat
2010-09-19 7:39 ` [PATCH 12/12] viafb: add documentation for proc interface Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920064354.2fc28219@bike.lwn.net \
--to=corbet@lwn.net \
--cc=FlorianSchandinat@gmx.de \
--cc=JosephChan@via.com.tw \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®