mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andy Walls <awalls@md.metrocast.net>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Dave Airlie <airlied@redhat.com>, Jon Smirl <jonsmirl@gmail.com>
Subject: Re: [PATCH] drm/sysfs: Provide per connector control of DRM KMS polling
Date: Mon, 20 Sep 2010 11:52:32 -0700	[thread overview]
Message-ID: <20100920185232.GA29263@kroah.com> (raw)
In-Reply-To: <1284987540.2242.29.camel@morgan.silverblock.net>

On Mon, Sep 20, 2010 at 08:59:00AM -0400, Andy Walls wrote:
> DRM KMS polling of connections providing errant EDID responses, or
> polling of "connectors" that have chips responding on DDC I2C bus
> address 0xA0/0xA1 with no actual physical connector nor EDID EEPROM,
> will create perpetual noise in dmesg and the system log every 10
> seconds.  Currently the user has apparently little recourse to silence
> these messages aside from replacing the offending cable, monitor, or
> graphics adapter.  That recourse is impossible for an unused DVI-D
> "connector" of an internal graphics processor on a motherboard that
> provides no physical DVI-D connector.
> 
> This change allows the root user to disable (and re-enable) DRM KMS
> connector polling on a per connector basis via sysfs, like so:
> 
>         # cat /sys/class/drm/card0/card0-DVI-D-1/polled
>         [hotplug_detectable] connect disconnect
>         
>         # echo > /sys/class/drm/card0/card0-DVI-D-1/polled
>         # cat /sys/class/drm/card0/card0-DVI-D-1/polled
>         hotplug_detectable connect disconnect
>         
>         # echo " connect  hotplug_detectable " > \
>         	/sys/class/drm/card0/card0-DVI-D-1/polled
>         # cat /sys/class/drm/card0/card0-DVI-D-1/polled
>         [hotplug_detectable] [connect] disconnect
>         
>         # echo > /sys/class/drm/card0/card0-DVI-D-1/polled
>         # cat /sys/class/drm/card0/card0-DVI-D-1/polled
>         hotplug_detectable connect disconnect
> 
> with the enabled poll types for the connector denoted in brackets: [].
> This allows the root user to silence DRM KMS log spam for locally known
> uncorrectable conditions.
> 
> Signed-off-by Andy Walls <awalls@md.metrocast.net>

You are adding a sysfs file, yet you forgot to add a file in
Documentation/ABI.  Please fix that and resend the patch.

thanks,

greg k-h

  parent reply	other threads:[~2010-09-20 18:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-20 12:59 Andy Walls
2010-09-20 18:29 ` Rafał Miłecki
2010-09-20 23:02   ` Andy Walls
2010-09-21  4:26     ` Alex Deucher
2010-09-21 17:30       ` Andy Walls
2010-09-22  5:30         ` Alex Deucher
2010-09-22 12:31           ` Andy Walls
2010-09-22 20:16             ` Andy Walls
2010-09-22 13:33           ` Jon Smirl
2010-09-22 21:07             ` Andy Walls
2010-09-22 22:05               ` Jon Smirl
2010-09-24 19:12               ` Alex Deucher
2010-09-26 18:12                 ` Andy Walls
2010-09-27 15:45                   ` Alex Deucher
2010-09-22  3:20     ` [PATCH v2 0/2] " Andy Walls
2010-09-22  3:20     ` [PATCH v2 1/2] " Andy Walls
2010-09-22  3:20     ` [PATCH v2 2/2] Doc/ABI: sysfs-drm initial document; "polled" entry Andy Walls
2010-09-22 15:06       ` Greg KH
2010-09-22 16:36         ` Andy Walls
2010-09-22 19:23           ` Greg KH
2010-09-20 18:52 ` Greg KH [this message]
2010-09-20 21:11   ` [PATCH] drm/sysfs: Provide per connector control of DRM KMS polling Andy Walls
2010-09-22  9:44     ` Florian Mickler
2010-09-22 12:49       ` Andy Walls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100920185232.GA29263@kroah.com \
    --to=greg@kroah.com \
    --cc=airlied@redhat.com \
    --cc=awalls@md.metrocast.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jonsmirl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome