mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	gregkh@suse.de, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH] FW_LOADER: fix kconfig dependency warning on HOTPLUG
Date: Tue, 21 Sep 2010 15:51:15 -0700	[thread overview]
Message-ID: <20100921225115.GA16237@kroah.com> (raw)
In-Reply-To: <4C99359D.9020700@oracle.com>

On Tue, Sep 21, 2010 at 03:45:49PM -0700, Randy Dunlap wrote:
> On 09/21/10 15:25, Greg KH wrote:
> > On Sat, Sep 18, 2010 at 01:23:08PM -0700, Randy Dunlap wrote:
> >>
> >> BTW, drivers/base/firmware_class.c should #include <linux/kobject.h>.
> > 
> > Why, it looks like it builds properly now, right?
> 
> Yes, it builds because (apparently) some other header file is causing
> <linux/kobject.h> to be sucked in.  That's not how we prefer to have header
> files used.
> 
> See Documentation/SubmitChecklist, item #1 (from Stephen Rothwell):
> 
> 1: If you use a facility then #include the file that defines/declares
>    that facility.  Don't depend on other header files pulling in ones
>    that you use.

Fair enough, care to send a patch?  :)

thanks,

greg k-h

      reply	other threads:[~2010-09-21 22:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-18 20:23 Randy Dunlap
2010-09-21 22:25 ` Greg KH
2010-09-21 22:45   ` Randy Dunlap
2010-09-21 22:51     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100921225115.GA16237@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome