From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Venkatesh Pallipadi <venki@google.com>
Cc: Prarit Bhargava <prarit@redhat.com>,
Simon Arlott <simon@fire.lp0.eu>,
x86@kernel.org, Clemens Ladisch <clemens@ladisch.de>,
linux-kernel@vger.kernel.org, Marc Jones <marcj303@gmail.com>,
Jordan Crouse <jcrouse@codeaurora.org>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86, HPET: ignore any PCI BARs that match an HPET we already know about
Date: Wed, 22 Sep 2010 14:19:36 -0600 [thread overview]
Message-ID: <201009221419.47283.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <20100922201547.3197.33702.stgit@bob.kio>
On Wednesday, September 22, 2010 02:15:47 pm Bjorn Helgaas wrote:
>
> We often discover the HPET early, via the static ACPI HPET table, before
> enumerating PCI devices. If the HPET is implemented as a PCI function,
> we will discover it again during PCI device enumeration. We must ignore
> the PCI function so we don't inadvertently move it out from under the
> driver.
>
> I think it's better to ignore *any* PCI BAR that matches a previously
> discovered HPET; that way we don't need platform-specific knowledge,
> and we won't have to add more quirks for future machines.
>
> This is for a regression from 2.6.34, but the reporter has been
> unable to test it yet.
>
> Reference: https://bugzilla.kernel.org/show_bug.cgi?id=18482
I've tried hard to find somebody who can test this, but nobody who
can reproduce the original failure has been able to test it. I
propose that we put it in linux-next and see what happens there.
Bjorn
next prev parent reply other threads:[~2010-09-22 20:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 20:15 Bjorn Helgaas
2010-09-22 20:19 ` Bjorn Helgaas [this message]
2010-09-22 20:21 ` H. Peter Anvin
2010-09-22 20:56 ` H. Peter Anvin
2010-09-22 21:52 ` Bjorn Helgaas
2010-09-22 22:02 ` H. Peter Anvin
2010-09-22 22:10 ` H. Peter Anvin
2010-09-22 22:37 ` Bjorn Helgaas
2010-09-22 22:39 ` H. Peter Anvin
2010-09-22 21:22 ` [tip:x86/pci] x86, pci: Ignore " tip-bot for Bjorn Helgaas
2010-09-22 21:48 ` Yinghai Lu
2010-09-22 22:41 ` Bjorn Helgaas
2010-09-22 22:53 ` H. Peter Anvin
2010-09-23 22:51 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009221419.47283.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=clemens@ladisch.de \
--cc=hpa@zytor.com \
--cc=jcrouse@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcj303@gmail.com \
--cc=mingo@redhat.com \
--cc=prarit@redhat.com \
--cc=simon@fire.lp0.eu \
--cc=tglx@linutronix.de \
--cc=venki@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®