From: Greg KH <greg@kroah.com>
To: Tracey Dent <tdent48227@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] Staging: rtl8187se: r8180.h: fixed alot of checkpatch.pl issues
Date: Wed, 22 Sep 2010 19:22:56 -0700 [thread overview]
Message-ID: <20100923022256.GB27057@kroah.com> (raw)
In-Reply-To: <20100922232458.GB18432@haskell.muteddisk.com>
On Wed, Sep 22, 2010 at 04:24:58PM -0700, matt mooney wrote:
> On 21:19 Mon 20 Sep , Tracey Dent wrote:
> > Fixed numerous coding style issues
> >
> The subject should be more specific as to what the patch does, such as
> "Staging: rtl8187se: r8180.h: whitespace cleanup."
>
> And the explanation in the commit should also be more specific. There are
> plenty of examples if you look through the log. Greg might except them as is,
> but any future patches should follow the advice mentioned. Next time for a
> patch of this nature remember to CC kernel-janitors too.
Why the janitor list? Do you really want that to be copied on every
cleanup patch I get like this? That would be a _lot_...
thanks,
greg k-h
next prev parent reply other threads:[~2010-09-23 2:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 1:19 Tracey Dent
2010-09-21 1:19 ` [PATCH 2/5] Staging: rtl8187se: r8180_hw: fixed a lot " Tracey Dent
2010-09-21 1:19 ` [PATCH 3/5] Staging: rtl8187se: r8180_rtl8225: " Tracey Dent
2010-09-21 1:19 ` [PATCH 4/5] Staging: rtl8187se: r8180_wx: fixed a lot of checkptahc.pl issues Tracey Dent
2010-09-21 1:19 ` [PATCH 5/5] Staging: rtl8187se: r8185b_init: fixed a lot of checkpatch.pl issues Tracey Dent
2010-09-22 23:24 ` [PATCH 1/5] Staging: rtl8187se: r8180.h: fixed alot " matt mooney
2010-09-23 0:24 ` T Dent
2010-09-23 2:22 ` Greg KH [this message]
2010-09-24 6:36 ` matt mooney
2010-09-24 15:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923022256.GB27057@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®