From: Roberto Sassu <roberto.sassu@polito.it>
To: linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] ecryptfs: calling __vfs_setxattr_noperm() in ecryptfs_setxattr()
Date: Fri, 24 Sep 2010 13:41:08 +0200 [thread overview]
Message-ID: <201009241341.12945.roberto.sassu@polito.it> (raw)
[-- Attachment #1: Type: Text/Plain, Size: 1985 bytes --]
Ecryptfs is a stackable filesystem which relies on lower filesystems the ability
of setting/getting extended attributes.
If there is a security module enabled on the system, it updates the 'security' field
of inodes according to the owned extended attribute set with the function vfs_setxattr().
When this function is performed on a ecryptfs filesystem the 'security' field is not
updated for the lower filesystem since the call security_inode_post_setxattr() is
missing for the lower inode.
This patch makes the function __vfs_setxattr_noperm() available for modules and
replaces the call to the setxattr() method of the lower inode with the exported function.
The patch applies on the latest checked commit (a850ea30374eb) of the mainline kernel.
Signed-off-by: Roberto Sassu <roberto.sassu@polito.it>
---
fs/ecryptfs/inode.c | 5 +++--
fs/xattr.c | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
index 3fbc942..e17f65d 100644
--- a/fs/ecryptfs/inode.c
+++ b/fs/ecryptfs/inode.c
@@ -32,6 +32,7 @@
#include <linux/crypto.h>
#include <linux/fs_stack.h>
#include <linux/slab.h>
+#include <linux/xattr.h>
#include <asm/unaligned.h>
#include "ecryptfs_kernel.h"
@@ -1109,8 +1110,8 @@ ecryptfs_setxattr(struct dentry *dentry, const char *name, const void *value,
goto out;
}
mutex_lock(&lower_dentry->d_inode->i_mutex);
- rc = lower_dentry->d_inode->i_op->setxattr(lower_dentry, name, value,
- size, flags);
+ rc = __vfs_setxattr_noperm(lower_dentry, name, value,
+ size, flags);
mutex_unlock(&lower_dentry->d_inode->i_mutex);
out:
return rc;
diff --git a/fs/xattr.c b/fs/xattr.c
index 01bb813..40f42af 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -106,6 +106,7 @@ int __vfs_setxattr_noperm(struct dentry *dentry, const char *name,
return error;
}
+EXPORT_SYMBOL_GPL(__vfs_setxattr_noperm);
int
--
1.7.2.3
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4707 bytes --]
next reply other threads:[~2010-09-24 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 11:41 Roberto Sassu [this message]
2010-10-05 6:23 ` [patch 1/1] ecryptfs: call " Tyler Hicks
2010-10-05 15:39 ` Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009241341.12945.roberto.sassu@polito.it \
--to=roberto.sassu@polito.it \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®