From: Sam Ravnborg <sam@ravnborg.org>
To: Tracey Dent <tdent48227@gmail.com>
Cc: greg@kroah.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/22] Staging: cx25821: Makefile:cleaned up makefile cflag lines
Date: Sat, 25 Sep 2010 12:28:01 +0200 [thread overview]
Message-ID: <20100925102801.GA3450@merkur.ravnborg.org> (raw)
In-Reply-To: <1285370890-8984-1-git-send-email-tdent48227@gmail.com>
On Fri, Sep 24, 2010 at 07:27:49PM -0400, Tracey Dent wrote:
> changed to use proper ccflags-y option
>
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
> drivers/staging/cx25821/Makefile | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/cx25821/Makefile b/drivers/staging/cx25821/Makefile
> index d0eb16e..2f1c73e 100644
> --- a/drivers/staging/cx25821/Makefile
> +++ b/drivers/staging/cx25821/Makefile
> @@ -7,7 +7,7 @@ cx25821-objs := cx25821-core.o cx25821-cards.o cx25821-i2c.o \
> obj-$(CONFIG_VIDEO_CX25821) += cx25821.o
> obj-$(CONFIG_VIDEO_CX25821_ALSA) += cx25821-alsa.o
>
> -EXTRA_CFLAGS += -Idrivers/media/video
> -EXTRA_CFLAGS += -Idrivers/media/common/tuners
> -EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
> -EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
> +ccflags-y := -Idrivers/media/video
> +ccflags-y := -Idrivers/media/common/tuners
> +ccflags-y := -Idrivers/media/dvb/dvb-core
> +ccflags-y := -Idrivers/media/dvb/frontends
This is wrong.
First you assign "ccflags-y" the value -Idrivers/media/video
And in next line you assign it a new value - loosing the old value.
It should lok like this:
> +ccflags-y := -Idrivers/media/video
> +ccflags-y += -Idrivers/media/common/tuners
> +ccflags-y += -Idrivers/media/dvb/dvb-core
> +ccflags-y += -Idrivers/media/dvb/frontends
In this way you append to the variable.
You said in another mil that it builds.
This tells me that either some of the assignments are not needes - or you just loose
something that you are not aware of.
Please go through all your patches and fix it up - I saw the above
bug in the two patches I looked at.
Sam
next prev parent reply other threads:[~2010-09-25 10:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 23:27 Tracey Dent
2010-09-24 23:27 ` [PATCH v2 02/22] Staging: cxlel: Makefile: cleaned " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 03/22] Staging: dream: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 04/22] Staging: dream: camera: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 05/22] Staging: dream: qdsp5: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 06/22] Staging: easycap: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 07/22] Staging: go7007: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 08/22] Staging: otus: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 09/22] Staging: rt2860: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 10/22] Staging: rt2870: " Tracey Dent
2010-09-24 23:27 ` [PATCH v2 11/22] Staging: rtl8187se: " Tracey Dent
2010-09-25 10:44 ` walter harms
2010-09-30 6:18 ` Greg KH
2010-09-24 23:28 ` [PATCH v2 12/22] Staging: rt8192e: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 13/22] Staging: rtl8192su: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 14/22] Staging: rtl8192su: ieee80211: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 15/22] Staging: rtl8192u: " Tracey Dent
2010-09-25 10:52 ` walter harms
2010-09-30 6:19 ` Greg KH
2010-09-24 23:28 ` [PATCH v2 16/22] Staging: rtl8192u: ieee80211: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 17/22] Staging: tm6000: Makefile: changed " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 18/22] Staging: usbip: Makefile: cleaned " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 19/22] Staging: vt6655: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 20/22] Staging: vt6656: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 21/22] Staging: wlags49_h2: " Tracey Dent
2010-09-24 23:28 ` [PATCH v2 22/22] Staging: wlags49_h25: " Tracey Dent
2010-09-25 10:28 ` Sam Ravnborg [this message]
2010-09-30 6:20 ` [PATCH v2 01/22] Staging: cx25821: Makefile:cleaned " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100925102801.GA3450@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®