From: Thomas Meyer <thomas@m3y3r.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
jbeulich@novell.com, r.marek@assembler.cz,
guenter.roeck@ericsson.com
Subject: 2.6.36-rc5+: drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask'
Date: Sun, 26 Sep 2010 23:17:50 +0200 [thread overview]
Message-ID: <201009262317.50500.thomas@m3y3r.de> (raw)
$ make V=2
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh - due to target is PHONY
CHK include/generated/compile.h
CC [M] drivers/hwmon/coretemp.o - due to target missing
drivers/hwmon/coretemp.c: In function 'coretemp_device_remove':
drivers/hwmon/coretemp.c:506: error: implicit declaration of function 'cpu_sibling_mask'
make[2]: *** [drivers/hwmon/coretemp.o] Error 1
make[1]: *** [drivers/hwmon] Error 2
make: *** [drivers] Error 2
above function is not defined on UP.
This commit introduced the error:
commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f
Author: Jan Beulich <jbeulich@novell.com>
Date: Mon Sep 13 10:23:05 2010 +0000
x86/hwmon: register alternate sibling upon CPU removal
Just like pkgtemp registers another core of the same package when one
gets removed, coretemp should register another hyperthread (if
available) in that situation.
As pointed out in the patch fixing the respective code in pkgtemp, the
list protectng mutex must be dropped before calling
coretemp_device_add(), and due to the restructured loop (including an
explicit return) the "safe" variant of the list iterator isn't needed
anymore.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Rudolf Marek <r.marek@assembler.cz>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
next reply other threads:[~2010-09-26 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-26 21:17 Thomas Meyer [this message]
2010-09-26 22:40 ` Randy Dunlap
2010-09-26 22:52 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009262317.50500.thomas@m3y3r.de \
--to=thomas@m3y3r.de \
--cc=guenter.roeck@ericsson.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=r.marek@assembler.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome