From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760309Ab0I0WkW (ORCPT ); Mon, 27 Sep 2010 18:40:22 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:33709 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756819Ab0I0WkV (ORCPT ); Mon, 27 Sep 2010 18:40:21 -0400 Date: Mon, 27 Sep 2010 15:40:41 -0700 (PDT) Message-Id: <20100927.154041.137841283.davem@davemloft.net> To: jgarzik@pobox.com Cc: linux@rainbow-software.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] de2104x: fix ethtool From: David Miller In-Reply-To: <4CA11546.8@pobox.com> References: <201009272341.50668.linux@rainbow-software.org> <4CA11546.8@pobox.com> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff Garzik Date: Mon, 27 Sep 2010 18:05:58 -0400 > On 09/27/2010 05:41 PM, Ondrej Zary wrote: >> When the interface is up, using ethtool breaks it because: >> a) link is put down but media_timer interval is not shortened to >> NO_LINK >> b) rxtx is stopped but not restarted >> >> Also manual 10baseT-HD (and probably FD too - untested) mode does not >> work - >> the link is forced up, packets are transmitted but nothing is >> received. >> Changing CSR14 value to match documentation (not disabling link check) >> fixes this. >> >> Signed-off-by: Ondrej Zary > > Acked-by: Jeff Garzik > > Good catch on the missing de_start_rxtx() Applied, thanks everyone.