From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758139Ab0I0Kpc (ORCPT ); Mon, 27 Sep 2010 06:45:32 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:34102 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757651Ab0I0Kpb (ORCPT ); Mon, 27 Sep 2010 06:45:31 -0400 Date: Mon, 27 Sep 2010 06:41:27 -0400 From: Neil Horman To: Jiri Olsa Cc: Andrew Morton , eugene@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] proc: making "limits" world readable Message-ID: <20100927104127.GA14660@hmsreliant.think-freely.org> References: <1285060255-15784-1-git-send-email-jolsa@redhat.com> <20100923145642.49f17b20.akpm@linux-foundation.org> <20100924105547.GA1818@jolsa.brq.redhat.com> <20100924162007.GD30252@hmsreliant.think-freely.org> <20100924113246.1221f435.akpm@linux-foundation.org> <20100927084923.GD1829@jolsa.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100927084923.GD1829@jolsa.brq.redhat.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 27, 2010 at 10:49:23AM +0200, Jiri Olsa wrote: > On Fri, Sep 24, 2010 at 11:32:46AM -0700, Andrew Morton wrote: > > On Fri, 24 Sep 2010 12:20:07 -0400 > > Neil Horman wrote: > > > > > On Fri, Sep 24, 2010 at 12:55:47PM +0200, Jiri Olsa wrote: > > > > On Thu, Sep 23, 2010 at 02:56:42PM -0700, Andrew Morton wrote: > > > > > On Tue, 21 Sep 2010 11:10:55 +0200 > > > > > Jiri Olsa wrote: > > > > > > > > > > > hi, > > > > > > > > > > > > I'd like to have the /proc//limits file world readable, > > > > > > > > > > Why? > > > > > > > > > > > > > having this will ease the task of system management for large install > > > > bases and where root privileges might be restricted > > > > > > > > jirka > > > > > > > I don't see a problem with making this file world readable. Doing so would be > > > in keeping with most of the other stats bearing files in /proc/. The only > > > reason I didn't make it world readable was because the getrlimit sematics > > > previously kept limit information private to the process, and I didn't want to > > > deviate from that. But as long as we're not making it world writeable I think > > > we're ok. > > > > > > Acked-by: Neil Horman > > > > > > > hm, OK, I can't really think of any realistic problem with exposing limits. > > > > The original patch had no signoff. Please resend, with a changelog > > which includes a *good* rationale for making the change. For example, > > a use case. > > > thanks for feedback, the patch is attached > > jirka > > --- > making the /proc//limits file world readable. > > Having the limits file world readable will ease the task of > system management on systems where root privileges might be > restricted. > > Having admin restricted with root proviledges, he/she could > not check other users process' limits. > > Also it'd align with most of the /proc stat files. > > wbr, > jirka > > > Signed-off-by: Jiri Olsa Acked-by: Neil Horman