mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	torvalds@linux-foundation.org, Fenghua Yu <fenghua.yu@intel.com>,
	Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined
Date: Mon, 27 Sep 2010 14:59:46 +0200	[thread overview]
Message-ID: <20100927125946.GB2862@elte.hu> (raw)
In-Reply-To: <1285588796-20956-1-git-send-email-guenter.roeck@ericsson.com>


* Guenter Roeck <guenter.roeck@ericsson.com> wrote:

> +#ifdef CONFIG_SMP
> +#endif
> +#ifdef CONFIG_SMP
> +#endif

Hm, this tickles my uglo-meter. Is there no cleaner way, preferably one 
that doesnt involve preprocessor directives?

Thanks,

	Ingo

  reply	other threads:[~2010-09-27 13:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-27 11:59 Guenter Roeck
2010-09-27 12:59 ` Ingo Molnar [this message]
2010-09-27 13:02   ` Pekka Enberg
2010-09-27 23:27     ` Guenter Roeck
2010-09-27 23:44       ` Linus Torvalds
2010-09-28  0:07         ` Guenter Roeck
2010-09-28  0:26         ` Guenter Roeck
2010-09-28  1:00           ` Linus Torvalds
2010-09-28  1:12             ` Guenter Roeck
2010-09-27 13:15   ` Guenter Roeck
2010-09-27 14:40   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100927125946.GB2862@elte.hu \
    --to=mingo@elte.hu \
    --cc=fenghua.yu@intel.com \
    --cc=guenter.roeck@ericsson.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®