mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Thomas Renninger <trenn@suse.de>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, jbaron@redhat.com
Subject: Re: Dynamic Debug module.ddebug fake param enhancements V4
Date: Tue, 28 Sep 2010 08:22:11 -0600	[thread overview]
Message-ID: <201009280822.11675.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <201009281425.19070.trenn@suse.de>

On Tuesday, September 28, 2010 06:25:18 am Thomas Renninger wrote:
> Greg: Do you mind pushing the first (1/4, V4) and the last (4/4)
> patch into your tree for linux-next and leave the two PNP patches
> out, please.
> 
> More PNP related discussion, below.
> 
> On Monday 27 September 2010 17:09:18 Bjorn Helgaas wrote:
> > On Monday, September 27, 2010 02:25:46 am Thomas Renninger wrote:
> > 
> > > What do you think (dev_dbg vs printk(KERN_DEBUG...)?
> ...
> > With the exception of the ones in pnp/resource.c that I want to convert
> > to dev_printk(KERN_DEBUG), I think all the pnp_dbg() uses are things
> > I used during PNP development and haven't ever needed since.
> 
> Ok. Sounds sane.
> I used the PNP parts as it nicely showed what the
> module.ddebug boot param is doing, but I agree it hasn't much
> advantage for PNP.
> 
> Whatabout compiling pnp in one module namespace, the first
> of the two PNP patches?

[2/4] looks reasonable to me.

> E.g. attached patch would be an on top patch which provides no
> functional change, just that a pnp.debug would be a module param:
> cat /sys/module/pnp/parameters/debug

As does the one below.

> ---------
> PNP: Set up pnp_debug via module and not via boot param.
> 
> Cleanup only, no functional change (pnp.debug can be enabled
> and disabled at runtime, but that's not a real enhancement).
> 
> This one depends on another PNP cleanup patch:
> PNP: Compile all pnp built-in stuff in one module namespace
> 
> Signed-off-by: Thomas Renninger <trenn@suse.de>
> 
> diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c
> index 88b3cde..9801918 100644
> --- a/drivers/pnp/core.c
> +++ b/drivers/pnp/core.c
> @@ -218,10 +218,5 @@ subsys_initcall(pnp_init);
>  int pnp_debug;
>  
>  #if defined(CONFIG_PNP_DEBUG_MESSAGES)
> -static int __init pnp_debug_setup(char *__unused)
> -{
> -	pnp_debug = 1;
> -	return 1;
> -}
> -__setup("pnp.debug", pnp_debug_setup);
> +module_param_named(debug, pnp_debug, int, 0644);
>  #endif
> 

  reply	other threads:[~2010-09-28 14:23 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-15 22:11 Dynamic Debug module.ddebug fake param enhancements Thomas Renninger
2010-09-15 22:11 ` [PATCH 1/4] Dynamic Debug: Introduce global fake module param module.ddebug - V3 Thomas Renninger
2010-09-17 19:54   ` Jason Baron
2010-09-17 21:52     ` Thomas Renninger
2010-09-20 18:44       ` Jason Baron
2010-09-24 12:18         ` Thomas Renninger
2010-09-24 12:28         ` Dynamic Debug module.ddebug fake param enhancements V4 Thomas Renninger
2010-09-24 14:56           ` Bjorn Helgaas
2010-09-27  8:25             ` Thomas Renninger
2010-09-27 15:09               ` Bjorn Helgaas
2010-09-28 12:25                 ` Thomas Renninger
2010-09-28 14:22                   ` Bjorn Helgaas [this message]
2010-10-06 20:59                     ` Greg KH
2010-09-24 12:28         ` [PATCH 1/4] Dynamic Debug: Introduce global fake module param module.ddebug - V4 Thomas Renninger
2010-10-06 21:16           ` Greg KH
2010-10-06 21:40             ` Thomas Renninger
2010-10-06 21:51               ` Greg KH
2010-09-24 12:28         ` [PATCH 2/4] PNP: Compile all pnp built-in stuff in one module namespace Thomas Renninger
2010-09-24 12:28         ` [PATCH 3/4] PNP: Use dev_dbg instead of dev_printk(KERN_DEBUG.. if DYNAMIC_DEBUG is compiled in Thomas Renninger
2010-09-24 12:28         ` [PATCH 4/4] kernel/module.c: Fix compiler warnings if debug " Thomas Renninger
2010-09-15 22:11 ` [PATCH 2/4] PNP: Compile all pnp built-in stuff in one module namespace Thomas Renninger
2010-09-15 22:11 ` [PATCH 3/4] PNP: Use dev_dbg instead of dev_printk(KERN_DEBUG.. if DYNAMIC_DEBUG is compiled in Thomas Renninger
2010-09-15 22:11 ` [PATCH 4/4] kernel/module.c: Fix compiler warnings if debug " Thomas Renninger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201009280822.11675.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=gregkh@suse.de \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®