From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760479Ab0I1Jl3 (ORCPT ); Tue, 28 Sep 2010 05:41:29 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:34839 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753813Ab0I1Jl2 (ORCPT ); Tue, 28 Sep 2010 05:41:28 -0400 Date: Tue, 28 Sep 2010 12:41:22 +0300 From: Felipe Balbi To: Grazvydas Ignotas Cc: "Balbi, Felipe" , Anton Vorontsov , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Chikkature Rajashekar, Madhusudhan" Subject: Re: [PATCH v4] power_supply: Add driver for TWL4030/TPS65950 BCI charger Message-ID: <20100928094122.GA7081@legolas.emea.dhcp.ti.com> Reply-To: balbi@ti.com References: <1285618704-8985-1-git-send-email-notasas@gmail.com> <20100928060554.GF2702@legolas.emea.dhcp.ti.com> <20100928084251.GC3900@legolas.emea.dhcp.ti.com> <20100928090637.GD3900@legolas.emea.dhcp.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 28, 2010 at 04:39:17AM -0500, Grazvydas Ignotas wrote: >On Tue, Sep 28, 2010 at 12:06 PM, Felipe Balbi wrote: >> On Tue, Sep 28, 2010 at 04:02:48AM -0500, Grazvydas Ignotas wrote: >>>> >>>> Charger event is SENT by charger driver when it verifies it's attached >>>> to a wall charger. >>> >>> Isn't that a job for musb/gadget? Detecting D+/D- being shorted by >>> charger or something like that? I don't think BCI is able to detect >>> charger. >> >> it's part of the charger detection right ? and according to trm, it's on >> the BCI (actually BCC) role to take care of that :-) > >Hm you are probably talking about TWL5031, which has redesigned >charger block that is named BCC. TWL4030 charger is different, called >BCI and requires software charger detection from what I see in it's >TRM. ok, might be that I got confused. Then it's ok the way it is. So we need other means to detect the charger :-p -- balbi