mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: "V, Hemanth" <hemanthv@ti.com>,
	Arun Murthy <arun.murthy@stericsson.com>,
	"lars@metafoo.de" <lars@metafoo.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"philipp.zabel@gmail.com" <philipp.zabel@gmail.com>,
	"robert.jarzmik@free.fr" <robert.jarzmik@free.fr>,
	"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
	"eric.y.miao@gmail.com" <eric.y.miao@gmail.com>,
	"rpurdie@rpsys.net" <rpurdie@rpsys.net>,
	"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	"STEricsson_nomadik_linux@list.st.com" 
	<STEricsson_nomadik_linux@list.st.com>
Subject: Re: [PATCH 1/7] pwm: Add pwm core driver
Date: Tue, 28 Sep 2010 16:35:01 +0300	[thread overview]
Message-ID: <20100928133501.GB8575@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20100928130610.GB20749@sortiz-mobl>

On Tue, Sep 28, 2010 at 08:06:11AM -0500, Samuel Ortiz wrote:
>On Tue, Sep 28, 2010 at 06:23:24PM +0530, Hemanth V wrote:
>> ----- Original Message ----- From: "Arun Murthy"
>> <arun.murthy@stericsson.com>
>>
>>
>> >The existing pwm based led and backlight driver makes use of the
>> >pwm(include/linux/pwm.h). So all the board specific pwm drivers will
>> >be exposing the same set of function name as in include/linux/pwm.h.
>> >As a result build fails in case of multi soc environments where each soc
>> >has a pwm device in it.
>>
>> This seems very specific to ST environment,
>No it's not. It's an issue Arun has hit while enabling one of the ST MFD chip,
>but he's tackling a generic issue.
>
>> looking at the driver list from
>> ( [PATCH 4/7] pwm: Align existing pwm drivers with pwm-core ) it seems
>> most multi SOC environments might support PWM in either one of the SOC.
>>
>> arch/arm/plat-mxc/pwm.c
>> arch/arm/plat-pxa/pwm.c
>> arch/arm/plat-samsung/pwm.c
>> arch/mips/jz4740/pwm.c
>> drivers/mfd/twl6030-pwm.c
>>
>> Unless people have examples of other SOCs which might use this,
>> the better approach might be to go for a custom driver rather than changing
>> the framework.
>I wouldn't call the current pwm code a framework. It's a bunch of header
>definitions that happens to work in the specific case of 1 pwm per
>sub architecture.
>What Arun is proposing is an actual framework. And it seems to be clean and
>simple enough.

FWIW, I agree with you Sam. Sooner or later, this will hit other SoCs.

-- 
balbi

  reply	other threads:[~2010-09-28 13:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28 10:35 [PATCH 0/7] PWM core driver for pwm based led and backlight driver Arun Murthy
2010-09-28 10:35 ` [PATCH 1/7] pwm: Add pwm core driver Arun Murthy
2010-09-28 12:53   ` Hemanth V
2010-09-28 13:06     ` Samuel Ortiz
2010-09-28 13:35       ` Felipe Balbi [this message]
2010-09-28 10:35 ` [PATCH 2/7] backlight:pwm: add an element 'name' to platform data Arun Murthy
2010-09-28 10:35 ` [PATCH 3/7] leds: pwm: add a new " Arun Murthy
2010-09-28 10:43   ` Sergei Shtylyov
2010-09-28 10:48     ` Arun MURTHY
2010-09-28 10:35 ` [PATCH 4/7] pwm: Align existing pwm drivers with pwm-core driver Arun Murthy
2010-09-28 10:35 ` [PATCH 5/7] platform: Update the pwm based led and backlight platform data Arun Murthy
2010-09-28 10:35 ` [PATCH 6/7] pwm: move existing pwm driver to drivers/pwm Arun Murthy
2010-09-28 10:35 ` [PATCH 7/7] pwm: Modify backlight and led Kconfig aligning to pwm core Arun Murthy
     [not found] <1285659648-21409-1-git-send-email-arun.murthy@stericsson.com>
     [not found] ` <1285659648-21409-2-git-send-email-arun.murthy@stericsson.com>
     [not found]   ` <4CA1AD2B.8000905@metafoo.de>
     [not found]     ` <F45880696056844FA6A73F415B568C69532DC2FB6B@EXDCVYMBSTM006.EQ1STM.local>
     [not found]       ` <4CA1BC16.3020702@metafoo.de>
     [not found]         ` <F45880696056844FA6A73F415B568C69532DC2FC60@EXDCVYMBSTM006.EQ1STM.local>
2010-09-28 21:04           ` [PATCH 1/7] pwm: Add pwm core driver Lars-Peter Clausen
2010-09-29  4:49             ` Arun MURTHY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100928133501.GB8575@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=STEricsson_nomadik_linux@list.st.com \
    --cc=akpm@linux-foundation.org \
    --cc=arun.murthy@stericsson.com \
    --cc=eric.y.miao@gmail.com \
    --cc=hemanthv@ti.com \
    --cc=kernel@pengutronix.de \
    --cc=kgene.kim@samsung.com \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    --cc=philipp.zabel@gmail.com \
    --cc=robert.jarzmik@free.fr \
    --cc=rpurdie@rpsys.net \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®