From: Jeff Layton <jlayton@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: smfrench@gmail.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH] cifs: set backing_dev_info on new S_ISREG inodes
Date: Thu, 30 Sep 2010 07:26:15 -0400 [thread overview]
Message-ID: <20100930072615.3eb07575@barsoom.rdu.redhat.com> (raw)
In-Reply-To: <20100929231730.GA6921@infradead.org>
On Wed, 29 Sep 2010 19:17:30 -0400
Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Sep 29, 2010 at 09:49:54AM -0400, Jeff Layton wrote:
> > Testing on very recent kernel (2.6.36-rc6) made this warning pop:
> >
> > WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x65/0x70()
> > Hardware name:
> > Dirtiable inode bdi default != sb bdi cifs
> >
> > ...the following patch fixes it and seems to be the obviously correct
> > thing to do for cifs.
>
> See my patch in the btrfs/default_backing_dev_info thread for the real
> fix for the underlying issue. But your patch won't harm either way.
>
Thanks Christoph. I looked to NFS as a model for this, which does a
very similar thing in nfs_fhget. It's probably reasonable for us to set
this here in case there is further churn in the VFS for this sort of
thing.
--
Jeff Layton <jlayton@redhat.com>
prev parent reply other threads:[~2010-09-30 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 13:49 Jeff Layton
2010-09-29 23:17 ` Christoph Hellwig
2010-09-30 11:26 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930072615.3eb07575@barsoom.rdu.redhat.com \
--to=jlayton@redhat.com \
--cc=hch@infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smfrench@gmail.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®