From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org
Subject: Re: [git pull] i915 regressions
Date: Sun, 3 Oct 2010 08:32:38 -0700 [thread overview]
Message-ID: <20101003083238.55885ac3@jbarnes-x201> (raw)
In-Reply-To: <8u3s94$gm76dr@orsmga002.jf.intel.com>
On Sun, 03 Oct 2010 11:33:36 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Hi Linus,
>
> still a fair few regressions popping up in the i915 driver. Julia
> spotted an old bug in our error handling that could cause the
> aperture to be consumed with unpinnable buffers, Keith found that the
> wait-for-vblank handling changes were not correct for DP, Jesse
> failed at basic math (and nobody spotted the mistake!) and I
I think I'm innocent on this one! I think Eric just introduced a merge
error when he pulled in the i915 changes for IPS. I was using do_div
(which modifies the first arg), but Eric changed to to div_u64 to fix a
build error of some kind, but forgot to fix things up due to the
changed semantics.
At any rate, it's a good fix and gives the IPS driver good GMCH power
values again.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2010-10-03 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-03 10:33 Chris Wilson
2010-10-03 15:32 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101003083238.55885ac3@jbarnes-x201 \
--to=jbarnes@virtuousgeek.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®