From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: x0095840@ti.com, linux-arm-kernel@lists.infradead.org,
Hiroshi.DOYU@nokia.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scatterlist: define SG chain for arm architecture
Date: Sun, 3 Oct 2010 12:28:39 +0100 [thread overview]
Message-ID: <20101003112839.GA32736@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20101003195758B.fujita.tomonori@lab.ntt.co.jp>
On Sun, Oct 03, 2010 at 08:02:52PM +0900, FUJITA Tomonori wrote:
> On Fri, 1 Oct 2010 17:39:58 +0100
> Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
>
> > On Fri, Oct 01, 2010 at 11:28:41AM -0500, Fernando Guzman Lugo wrote:
> > > Define SG chain for ARM architecture in order to work
> > > with big buffers. This patch is needed in order to
> > > iovmm users can pass a big buffer to map it and ARM
> > > architecture has not issues using SG chain.
> > >
> > > This change was suggested by FUJITA Tomonori.
> >
> > Have you audited all places where SG lists are used in the ARM
> > architecture to ensure that SG chain support is safe? (That
> > goes for ARM generic code and ARM specific drivers.)
>
> As far as I know, only SCSI actually uses SG chain feature (that is,
> sending chained scatter lists). All SCSI drivers were converted when
> we added SG chain feature. So what you need to care about is the dma
> code.
>
> There are only several files that actually use scatter list under
> arch/arm.
>
> >From a quick look, arch/arm/mm/dma-mapping.c,
> arch/arm/common/dmabounce.c, arch/arm/kernel/dma.c, and
> arch/arm/include/asm/dma-mapping.h looks fine.
>
> arm/mach-imx/dma-v1.c also looks like to use chained sg API properly
> (but this isn't used with SCSI, right?).
>
> Seems that arch/arm/plat-omap/iovmm.c can handle the chained SG
> too. It doesn't allocate the chained SG now though.
There's also RiscPC and its SCSI drivers could well be an issue for SG
chaining. They have to manually save the SCSI 'data pointer' (down to
the byte position in the SG chain and be able to restore a previously
saved point.) This code was written before SG chaining ever appeared,
and although it has been partly fixed up, it's probably buggy if SG
chaining were to be enabled.
If it's just OMAP users who wish to enable SG chaining, then the sane
thing to do would be to make the definition of the macro conditional
on OMAP.
next prev parent reply other threads:[~2010-10-03 11:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 16:28 Fernando Guzman Lugo
2010-10-01 16:39 ` Russell King - ARM Linux
2010-10-01 18:54 ` Guzman Lugo, Fernando
2010-10-03 11:02 ` FUJITA Tomonori
2010-10-03 11:28 ` Russell King - ARM Linux [this message]
2010-10-03 11:34 ` FUJITA Tomonori
2010-12-02 17:41 ` Guzman Lugo, Fernando
2010-12-06 19:23 ` Guzman Lugo, Fernando
-- strict thread matches above, loose matches on Subject: below --
2010-10-01 3:22 Fernando Guzman Lugo
2010-10-01 3:50 ` Guzman Lugo, Fernando
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101003112839.GA32736@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Hiroshi.DOYU@nokia.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®