From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755042Ab0JCUvc (ORCPT ); Sun, 3 Oct 2010 16:51:32 -0400 Received: from pfepa.post.tele.dk ([195.41.46.235]:53711 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754887Ab0JCUvb (ORCPT ); Sun, 3 Oct 2010 16:51:31 -0400 Date: Sun, 3 Oct 2010 22:51:28 +0200 From: Sam Ravnborg To: walter harms Cc: Tracey Dent , greg@kroah.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines Message-ID: <20101003205128.GA16185@merkur.ravnborg.org> References: <1286037489-28439-1-git-send-email-tdent48227@gmail.com> <4CA879A1.3070400@bfs.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CA879A1.3070400@bfs.de> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 03, 2010 at 02:40:01PM +0200, walter harms wrote: > > > Tracey Dent schrieb: > > Changed to use the proper ccflags-y option > > > > Signed-off-by: Tracey Dent > > --- > > drivers/staging/cx25821/Makefile | 8 ++++---- > > 1 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/cx25821/Makefile b/drivers/staging/cx25821/Makefile > > index d0eb16e..6448364 100644 > > --- a/drivers/staging/cx25821/Makefile > > +++ b/drivers/staging/cx25821/Makefile > > @@ -7,7 +7,7 @@ cx25821-objs := cx25821-core.o cx25821-cards.o cx25821-i2c.o \ > > obj-$(CONFIG_VIDEO_CX25821) += cx25821.o > > obj-$(CONFIG_VIDEO_CX25821_ALSA) += cx25821-alsa.o > > > > -EXTRA_CFLAGS += -Idrivers/media/video > > -EXTRA_CFLAGS += -Idrivers/media/common/tuners > > -EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core > > -EXTRA_CFLAGS += -Idrivers/media/dvb/frontends > > +ccflags-y := -Idrivers/media/video > > +ccflags-y += -Idrivers/media/common/tuners > > +ccflags-y += -Idrivers/media/dvb/dvb-core > > +ccflags-y += -Idrivers/media/dvb/frontends > > they have invented vpath for this, did they ? > note: I am not familiar with the linux makefile. vpath is not the answer here. Note that Tracy dent did the simple replacement of EXTRA_CFLAGS with ccflags-y. The Makefiles could in many cases benefit from general cleanups - which many of your futher comments is a good indicator of. Sam