From: David Miller <davem@davemloft.net>
To: masa-korg@dsn.okisemi.com
Cc: mkl@pengutronix.de, sameo@linux.intel.com, chripell@fsfe.org,
meego-dev@meego.com, morinaga526@dsn.okisemi.com,
joel.clark@intel.com, kok.howg.ewe@intel.com,
socketcan-core@lists.berlios.de, yong.y.wang@intel.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
margie.foster@intel.com, qi.wang@intel.com,
andrew.chih.howe.khor@intel.com, wg@grandegger.com
Subject: Re: [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_CAN driver to 2.6.35
Date: Tue, 05 Oct 2010 11:45:06 -0700 (PDT) [thread overview]
Message-ID: <20101005.114506.184852374.davem@davemloft.net> (raw)
In-Reply-To: <002e01cb6486$2ed72cc0$66f8800a@maildom.okisemi.com>
From: "Masayuki Ohtake" <masa-korg@dsn.okisemi.com>
Date: Tue, 5 Oct 2010 21:09:30 +0900
> On Tuesday, October 05, 2010 8:08 PM, Marc Kleine-Budde wrote:
>> If FIFO is working you might also think about NAPI.
>
> I think NAPI isn't necessary for our CAN driver.
> NAPI is for high-speed networking.
> CAN is NOT high-speed.
>
> In fact, some accepted CAN drivers don't have NAPI.
NAPI is not just for performance concerns.
It greatly simplifies the locking since all packet processing paths
run only in software interrupt context, never in hardware interrupt
context.
We encourage all new drivers that can use NAPI to do so, just because
recent driver submissions do not do this doesn't mean we should
continue such a mistake ;-)
next prev parent reply other threads:[~2010-10-05 18:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 10:24 Masayuki Ohtak
2010-09-27 8:38 ` Wolfgang Grandegger
2010-09-30 9:10 ` Wolfgang Grandegger
2010-09-30 18:50 ` David Miller
2010-10-01 10:02 ` Masayuki Ohtake
2010-10-01 12:40 ` Wolfgang Grandegger
2010-10-05 10:21 ` Masayuki Ohtake
2010-10-05 11:08 ` Marc Kleine-Budde
2010-10-05 12:09 ` Masayuki Ohtake
2010-10-05 18:45 ` David Miller [this message]
2010-10-06 3:07 ` Masayuki Ohtake
2010-10-06 3:09 ` David Miller
2010-10-06 9:12 ` Wolfgang Grandegger
2010-10-12 7:09 ` Masayuki Ohtake
2010-10-12 7:42 ` Wolfgang Grandegger
2010-10-12 7:56 ` Marc Kleine-Budde
2010-10-13 4:23 ` Masayuki Ohtake
2010-10-13 7:38 ` Marc Kleine-Budde
2010-10-13 10:09 ` Masayuki Ohtake
2010-10-13 11:08 ` Wolfgang Grandegger
2010-10-13 12:05 ` Masayuki Ohtake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101005.114506.184852374.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.chih.howe.khor@intel.com \
--cc=chripell@fsfe.org \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=meego-dev@meego.com \
--cc=mkl@pengutronix.de \
--cc=morinaga526@dsn.okisemi.com \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=wg@grandegger.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome