From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "N.P.S." <napohybelskurwysynom2010@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: mmotm 2010-09-28-16-13 uploaded
Date: Tue, 5 Oct 2010 11:46:21 +1100 [thread overview]
Message-ID: <20101005114621.d64561cb.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20101004161600.8cdf4e0c.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 2059 bytes --]
Hi,
On Mon, 4 Oct 2010 16:16:00 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Thu, 30 Sep 2010 21:39:26 +0200
> "N.P.S." <napohybelskurwysynom2010@gmail.com> wrote:
>
> > Here is a patch that removes duplicate includes introduced in -next and
> > -mmotm
> >
> > --
> > Zimny Lech
> >
> > arch/arm/mach-omap2/board-rx51-peripherals.c | 1 -
> > arch/arm/mm/flush.c | 1 -
> > arch/xtensa/include/asm/coprocessor.h | 1 -
> > drivers/mmc/host/ushc.c | 1 -
> > drivers/staging/ath6kl/os/linux/include/ar6000_drv.h | 1 -
> > drivers/staging/batman-adv/soft-interface.c | 1 -
> > drivers/staging/bcm/headers.h | 1 -
> > drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 4 ----
> > drivers/staging/brcm80211/brcmfmac/wl_cfg80211.h | 1 -
> > drivers/staging/brcm80211/brcmfmac/wl_iw.c | 4 ----
> > drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 1 -
> > drivers/staging/rtl8712/drv_types.h | 1 -
> > drivers/staging/rtl8712/osdep_service.h | 1 -
> > drivers/staging/westbridge/astoria/gadget/cyasgadget.h | 3 ---
> > sound/soc/fsl/mpc5200_dma.c | 1 -
> > 15 files changed, 23 deletions(-)
>
> Removal of duplicated includes is a somewhat dangerous thing. If
> someone else says "hey, there's a duplicated include" and then fixes
> it, and if this patch removes the other include then whoops, we broke
> the build. This has happened before.
>
> So I'd ask that you redo and resend this patch shortly after 2.6.36 is
> released please, so I can get it into mainline quickly thus minimising
> the opportunity for such breakage.
Or could it be broken up and sent to the appropriate maintainers?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2010-10-05 0:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 23:13 akpm
2010-09-29 0:27 ` N.P.S. N.P.S.
2010-09-29 0:44 ` Andrew Morton
2010-09-29 12:19 ` Arnd Bergmann
2010-09-29 12:57 ` N.P.S. N.P.S.
2010-09-29 0:49 ` Valdis.Kletnieks
2010-09-29 0:57 ` N.P.S. N.P.S.
2010-09-29 1:19 ` Valdis.Kletnieks
2010-09-29 0:49 ` N.P.S. N.P.S.
2010-09-29 1:13 ` Randy Dunlap
2010-09-29 5:55 ` Andrew Morton
2010-09-29 1:25 ` Valdis.Kletnieks
2010-09-29 9:15 ` N.P.S. N.P.S.
2010-09-29 15:00 ` Randy Dunlap
2010-09-29 15:04 ` Na Pohybel
[not found] ` <AANLkTikk+k7WJEDv9dQoJDyMdz8NCM8LOb5kW=xyWK71@mail.gmail.com>
2010-09-29 9:17 ` Fwd: " N.P.S. N.P.S.
2010-09-29 13:13 ` N.P.S. N.P.S.
2010-09-29 15:01 ` Randy Dunlap
2010-09-29 15:05 ` Na Pohybel
2010-09-30 16:59 ` Na Pohybel
2010-09-30 18:25 ` N.P.S.
2010-09-30 19:39 ` N.P.S.
2010-10-01 15:40 ` Zimny Lech
2010-10-04 13:43 ` Zimny Lech
2010-10-04 23:16 ` Andrew Morton
2010-10-04 23:33 ` Zimny Lech
2010-10-04 23:43 ` Andrew Morton
2010-10-20 21:58 ` [PATCH] Removal of duplicate includes from many files N.P.S.
2010-10-20 23:15 ` Andrew Morton
2010-10-20 23:25 ` Zimny Lech
2010-10-24 1:48 ` mmotm 2010-09-28-16-13 uploaded Maciej W. Rozycki
2010-10-05 0:46 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101005114621.d64561cb.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=napohybelskurwysynom2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®