From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Igor Grinberg <grinberg@compulab.co.il>,
Marek Vasut <marek.vasut@gmail.com>,
linux-arm-kernel@lists.infradead.org, vapier@gentoo.org,
khilman@deeprootsystems.com, linux-kernel@vger.kernel.org,
pavel@ucw.cz, linux-input@vger.kernel.org, eric.y.miao@gmail.com,
akpm@linux-foundation.org
Subject: Re: [PATCH v2] Input: Make ADS7846 independent on regulator
Date: Tue, 5 Oct 2010 20:35:08 +0100 [thread overview]
Message-ID: <20101005203508.7df590db@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20101005185942.GA22808@opensource.wolfsonmicro.com>
> If the board doesn't use regulators you can just disable the regulator
> API at which point it compiles out into stubs which report success -
> this has been the case from day one. There's only an issue if the board
> has a regulator configuration which is partially visible to software.
Which is quite likely on anything complex and means that hardcoding
regulator assumptions is bad.
I actually see two ways of attacking that, one is that the dummy
regulator *and* the compiled in regulator system have a standard
regulator value that can be passed which means "report success, move
along nothing to see" that could be passed into drivers, the other is to
not stick the stuff in drivers.
I suspect the former may be cleaner ?
Alan
next prev parent reply other threads:[~2010-10-05 19:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 7:09 Marek Vasut
2010-09-07 12:23 ` Igor Grinberg
2010-09-07 12:53 ` Mark Brown
2010-09-09 8:27 ` Marek Vasut
2010-09-09 9:41 ` Mark Brown
2010-10-01 0:20 ` Marek Vasut
2010-10-05 6:49 ` Igor Grinberg
2010-10-05 8:21 ` Marek Vasut
2010-10-05 16:16 ` Dmitry Torokhov
2010-10-05 16:40 ` Mark Brown
2010-10-05 18:07 ` Dmitry Torokhov
2010-10-05 18:59 ` Mark Brown
2010-10-05 19:35 ` Alan Cox [this message]
2010-10-05 20:42 ` Mark Brown
2010-10-05 22:09 ` Linus Walleij
2010-10-05 22:52 ` Mark Brown
2010-10-06 8:01 ` Linus Walleij
2010-10-06 15:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101005203508.7df590db@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=grinberg@compulab.co.il \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=pavel@ucw.cz \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®