From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
Pavel Emelyanov <xemul@parallels.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
xiyou.wangcong@gmail.com
Subject: Re: [PATCH v2] procfs: fix numbering in /proc/locks
Date: Wed, 6 Oct 2010 18:36:58 +0800 [thread overview]
Message-ID: <20101006103658.GC5724@cr0.nay.redhat.com> (raw)
In-Reply-To: <4CAB1693.2080301@redhat.com>
On Tue, Oct 05, 2010 at 02:14:11PM +0200, Jerome Marchand wrote:
>On 09/30/2010 02:38 PM, Jerome Marchand wrote:
...
>> - f->private = (void *)1;
>> + f->private = (void *) (*pos + 1);
>
>That cast trigger a warning on some arch:
>"warning: cast to pointer from integer of different size"
>
>There is no real risk here. At worst /proc/locks will show wrong number
>if there is more than 2^32 locks, but should I mute the warning it with
>something like:
> f->private = (void *) (size_t) (*pos + 1);
>?
Or maybe cast to (void *) (unsigned long)?
next prev parent reply other threads:[~2010-10-06 10:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 12:38 Jerome Marchand
2010-10-01 7:03 ` Américo Wang
2010-10-01 7:13 ` Pavel Emelyanov
2010-10-05 12:14 ` Jerome Marchand
2010-10-06 10:36 ` Américo Wang [this message]
2010-10-07 23:27 ` Andrew Morton
2010-10-08 8:29 ` Jerome Marchand
2010-10-15 11:32 ` [PATCH v3] " Jerome Marchand
2010-10-22 21:27 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006103658.GC5724@cr0.nay.redhat.com \
--to=xiyou.wangcong@gmail.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome