mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans Rosenfeld <hans.rosenfeld@amd.com>
To: Stephane Eranian <eranian@google.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, "mingo@elte.hu" <mingo@elte.hu>,
	"Richter, Robert" <robert.richter@amd.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Herrmann3, Andreas" <Andreas.Herrmann3@amd.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"fweisbec@gmail.com" <fweisbec@gmail.com>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"acme@redhat.com" <acme@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	"eranian@gmail.com" <eranian@gmail.com>
Subject: Re: [RFC 0/3] Basic support for LWP
Date: Thu, 7 Oct 2010 16:20:39 +0200	[thread overview]
Message-ID: <20101007142039.GC17424@escobedo.osrc.amd.com> (raw)
In-Reply-To: <AANLkTin+PXzz4qJHX6kHiQW8Rqdrv=hrvq4iWuaOnGiV@mail.gmail.com>

On Thu, Oct 07, 2010 at 10:11:42AM -0400, Stephane Eranian wrote:
> On Thu, Oct 7, 2010 at 3:59 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> > On 10/07/2010 03:46 AM, Stephane Eranian wrote:
> >>
> >> As for the patch itself, I am not an expert at xsave/xrstor, but it seems to
> >> me you could decouple LWP from FPU. I think  Brian had the same comment.
> >> I suspect this can be done and it will certainly look cleaner.
> >>
> >
> > Well, once you're using XSAVE you're not decoupled from the FPU.  Worse,
> > if you're using XSAVE and not honoring CR0.TS you have a major design flaw.
> >
> Is that to say, that if you use LWP you will have to save/restore FPU state even
> though you're not actually using it?

No, you don't necessarily have to care about the FPU stuff. XSAVE can
save different states individually to the same buffer, and XRSTOR can
restore them individually. You just have to make sure CR0.TS is not
set when you execute the XSAVE or XRSTOR instruction.

That's what I did and it worked :)


Hans


-- 
%SYSTEM-F-ANARCHISM, The operating system has been overthrown


  reply	other threads:[~2010-10-07 14:20 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1286212172-654419-1-git-send-email-hans.rosenfeld@amd.com>
2010-10-04 22:13 ` Thomas Gleixner
2010-10-05 14:51   ` Hans Rosenfeld
2010-10-05 15:34     ` Thomas Gleixner
2010-10-05 18:27       ` Hans Rosenfeld
2010-10-05 18:30         ` Hans Rosenfeld
2010-10-05 18:30         ` [RFC 1/3] Cleanup xsave/xrstor support Hans Rosenfeld
2010-10-05 18:30         ` [RFC 2/3] Allow saving of individual states in fpu_xsave() Hans Rosenfeld
2010-10-05 18:30         ` [RFC 3/3] Save/restore LWP state in context switches Hans Rosenfeld
2010-10-06 11:12           ` Brian Gerst
2010-10-07 14:58             ` Hans Rosenfeld
2010-11-23 20:41             ` [RFC 0/2] FPU/xsave rework in preparation for LWP Hans Rosenfeld
2010-11-23 20:41             ` [RFC 1/2] x86, xsave: cleanup xsave/xrstor support Hans Rosenfeld
2010-11-23 20:41             ` [RFC 2/2] x86, xsave: rework xsave support Hans Rosenfeld
2010-11-25  0:36               ` Brian Gerst
2010-10-05 19:05         ` [RFC 0/3] Basic support for LWP Ingo Molnar
2010-10-06  7:35           ` Robert Richter
     [not found]             ` <AANLkTi=T0QmcKeZcgcR+GKk-9OwQUB_x8XdHiNuU7tE_@mail.gmail.com>
2010-10-07 10:46               ` Stephane Eranian
2010-10-07 13:59                 ` H. Peter Anvin
2010-10-07 14:11                   ` Stephane Eranian
2010-10-07 14:20                     ` Hans Rosenfeld [this message]
2010-10-07 14:20                     ` H. Peter Anvin
2010-10-07 14:25                       ` Stephane Eranian
2010-10-07 14:47                         ` H. Peter Anvin
2010-10-07 15:12                   ` Stephane Eranian
2010-10-05 18:43     ` Davidlohr Bueso
2010-10-06 10:26       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101007142039.GC17424@escobedo.osrc.amd.com \
    --to=hans.rosenfeld@amd.com \
    --cc=Andreas.Herrmann3@amd.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=eranian@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=robert.richter@amd.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®