From: David Miller <davem@davemloft.net>
To: grant.likely@secretlab.ca
Cc: dilinger@queued.net, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, sam@ravnborg.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 1/2 v2] of: move phandle/ihandle into types.h and export to userspace
Date: Fri, 08 Oct 2010 10:17:59 -0700 (PDT) [thread overview]
Message-ID: <20101008.101759.193728130.davem@davemloft.net> (raw)
In-Reply-To: <20101008171210.GE3863@angua.secretlab.ca>
From: Grant Likely <grant.likely@secretlab.ca>
Date: Fri, 8 Oct 2010 11:12:10 -0600
> On Fri, Oct 08, 2010 at 12:43:54AM -0700, Andres Salomon wrote:
>>
>> We need phandle for some exported sparc headers; of.h isn't an
>> exported header, and it would be silly to export it when all we
>> really need is one or two types from it. Also, later patches
>> use phandle in structs that are exported to userspace, so export
>> a __kernel_phandle type.
>>
>> Signed-off-by: Andres Salomon <dilinger@queued.net>
>
> Looks okay to me. I'm build testing it now on powerpc and
> microblaze. If davem agrees, then I'll pick it up into my
> devicetree-next branch.
>
> Question though; since sparc userspace is the only user of this,
> should the types.h header avoid exposing it on non-sparc?
I can't think of anything in Sparc userspace that needs the
phandle_t type.
In fact I was a bit confused when you asked Andres to expose
it to userspace.
What I remember from a previous thread is that some other platforms
use the type in their DT device-tree building tools or whatever, but
they define phandle_t for themselves I remember specifically
mentioning sparc has no use for this currently.
next prev parent reply other threads:[~2010-10-08 17:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 7:43 Andres Salomon
2010-10-08 17:12 ` Grant Likely
2010-10-08 17:17 ` David Miller [this message]
2010-10-08 17:36 ` Grant Likely
2010-10-08 17:45 ` David Miller
2010-10-08 18:27 ` Grant Likely
2010-10-08 18:38 ` Andres Salomon
2010-10-08 18:34 ` [PATCH] sparc: stop exporting openprom.h header Andres Salomon
2010-10-08 18:52 ` David Miller
2010-10-08 19:00 ` Grant Likely
2010-10-08 19:02 ` David Miller
2010-10-08 21:34 ` Andres Salomon
2010-10-09 8:51 ` Grant Likely
2010-10-09 20:48 ` Andres Salomon
2010-10-10 5:13 ` Grant Likely
2010-10-10 7:19 ` Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008.101759.193728130.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dilinger@queued.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome