From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757969Ab0JJQ5H (ORCPT <rfc822;w@1wt.eu>);
	Sun, 10 Oct 2010 12:57:07 -0400
Received: from xenotime.net ([72.52.115.56]:50712 "HELO xenotime.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP
	id S1755532Ab0JJQ5G (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 10 Oct 2010 12:57:06 -0400
Date: Sun, 10 Oct 2010 09:57:03 -0700
From: Randy Dunlap <rdunlap@xenotime.net>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
        Linux Embedded <linux-embedded@vger.kernel.org>,
        Linux FS Devel <linux-fsdevel@vger.kernel.org>,
        Tim Bird <tim.bird@am.sony.com>
Subject: Re: [PATCH 15/16] pramfs: test module
Message-Id: <20101010095703.aeae2f15.rdunlap@xenotime.net>
In-Reply-To: <4CB1EBDD.8050509@gmail.com>
References: <4CB1EBDD.8050509@gmail.com>
Organization: YPO4
X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 10 Oct 2010 18:37:49 +0200 Marco Stornelli wrote:

> From: Marco Stornelli <marco.stornelli@gmail.com>
> 
> Test module.
> 
> Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
> ---
> diff -Nurp linux-2.6.36-orig/fs/pramfs/pramfs_test.c linux-2.6.36/fs/pramfs/pramfs_test.c
> --- linux-2.6.36-orig/fs/pramfs/pramfs_test.c	1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.36/fs/pramfs/pramfs_test.c	2010-09-14 18:49:52.000000000 +0200
> @@ -0,0 +1,49 @@
> +/*
> + * FILE NAME fs/pramfs/namei.c
> + *
> + * BRIEF DESCRIPTION
> + *
> + * Pramfs test module.
> + *
> + * Copyright 2009-2010 Marco Stornelli <marco.stornelli@gmail.com>
> + * Copyright 2003 Sony Corporation
> + * Copyright 2003 Matsushita Electric Industrial Co., Ltd.
> + * 2003-2004 (c) MontaVista Software, Inc. , Steve Longerbeam
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +#include <linux/module.h>
> +#include <linux/version.h>
> +#include <linux/init.h>
> +#include <linux/fs.h>
> +#include "pram.h"
> +
> +int __init test_pramfs_write(void)
> +{
> +	struct pram_super_block *psb;
> +
> +	psb = get_pram_super();
> +	if (!psb) {
> +		printk(KERN_ERR
> +		"%s: PRAMFS super block not found (not mounted?)\n",
> +		__func__);

Above 2 lines need to indented more.

> +		return 1;
> +	}
> +
> +	/*
> +	 * Attempt an unprotected clear of checksum information in the
> +	 * superblock, this should cause a kernel page protection fault.
> +	 */
> +	printk("%s: writing to kernel VA %p\n", __func__, psb);
> +	psb->s_sum = 0;
> +
> +	return 0;
> +}
> +
> +void test_pramfs_write_cleanup(void) {}
> +
> +/* Module information */
> +MODULE_LICENSE("GPL");
> +module_init(test_pramfs_write);
> +module_exit(test_pramfs_write_cleanup);


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***