From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755660Ab0JKRFk (ORCPT ); Mon, 11 Oct 2010 13:05:40 -0400 Received: from cpoproxy3-pub.bluehost.com ([67.222.54.6]:54276 "HELO cpoproxy3-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755628Ab0JKRFh (ORCPT ); Mon, 11 Oct 2010 13:05:37 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org; h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=cocdj1h5fTZSbxavo6eKF+vV3QmXHsXnSaWZv4MEoX+Spok/Ql3LGicAzB0Hjurcsy+zuUyq4KkDluelubwYeLimno7SqCiUZvh2nFqIW/aL6Q3XLwh0uZTBjpbOs4we; Date: Mon, 11 Oct 2010 10:08:49 -0700 From: Jesse Barnes To: Thomas Gleixner Cc: LKML , linux-arch@vger.kernel.org, Linus Torvalds , Andrew Morton , x86@kernel.org, Peter Zijlstra , Benjamin Herrenschmidt , Paul Mundt , Russell King , David Woodhouse , Yinghai Lu , Grant Likely , "Eric W. Biederman" Subject: Re: [patch 33/47] pci: Cleanup the irq_desc mess in msi Message-ID: <20101011100849.072b9ba6@jbarnes-desktop> In-Reply-To: <20100930221741.720879189@linutronix.de> References: <20100930221351.682772535@linutronix.de> <20100930221741.720879189@linutronix.de> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 67.174.193.198 authed with jbarnes@virtuousgeek.org} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Sep 2010 23:17:18 -0000 Thomas Gleixner wrote: > Handing down irq_desc to msi just so that msi can access > irq_desc.irq_data.msi_desc is a pretty stupid idea. The calling code > can hand down a pointer to msi_desc so msi code does not need to know > about the irq descriptor at all. > > Signed-off-by: Thomas Gleixner > --- Looks like a good cleanup. Acked-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center